Skip to content

JACOBIN-915 Some jj_test.go functions fail on Windows when shell is not bash #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
texadactyl merged 2 commits into from
May 9, 2026
Merged

JACOBIN-915 Some jj_test.go functions fail on Windows when shell is not bash #485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4136ac1
JACOBIN-915 Some jj_test.go functions fail on Windows when shell is n…
texadactyl May 9, 2026
d3e6e72
Merge branch 'main' of https://github.com/texadactyl/jacobin
texadactyl May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 56 additions & 4 deletions src/gfunction/misc/jj_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"jacobin/src/trace"
"jacobin/src/types"
"os"
"runtime"
"strings"
"testing"
)
Expand Down Expand Up @@ -522,9 +523,27 @@ func TestJjTraceInst(t *testing.T) {

func TestJjSubProcess_Success(t *testing.T) {
trace.Init()

// "echo" is a cmd.exe built-in on Windows, requiring the shell to invoke it.
// On POSIX, we can call echo directly as a subprocess.
var cmdLine []*object.Object
if runtime.GOOS == "windows" {
cmdLine = []*object.Object{
object.StringObjectFromGoString("cmd.exe"),
object.StringObjectFromGoString("/C"),
object.StringObjectFromGoString("echo"),
object.StringObjectFromGoString("hello"),
}
} else {
cmdLine = []*object.Object{
object.StringObjectFromGoString("echo"),
object.StringObjectFromGoString("hello"),
}
}

subpObj := &object.Object{
FieldTable: map[string]object.Field{
"commandLine": {Fvalue: []*object.Object{object.StringObjectFromGoString("echo"), object.StringObjectFromGoString("hello")}},
"commandLine": {Fvalue: cmdLine},
"classpath": {Fvalue: []*object.Object{}},
"stdout": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
"stderr": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
Expand Down Expand Up @@ -568,9 +587,27 @@ func TestJjSubProcess_Failure(t *testing.T) {

func TestJjSubProcess_ExitError(t *testing.T) {
trace.Init()

// Use a command that is guaranteed to fail with a non-zero exit code
// on each platform. "ls" is POSIX-only; on Windows we use "dir" via cmd.exe.
var cmdLine []*object.Object
if runtime.GOOS == "windows" {
cmdLine = []*object.Object{
object.StringObjectFromGoString("cmd.exe"),
object.StringObjectFromGoString("/C"),
object.StringObjectFromGoString("dir"),
object.StringObjectFromGoString("C:\\nonexistentdirectory"),
}
} else {
cmdLine = []*object.Object{
object.StringObjectFromGoString("ls"),
object.StringObjectFromGoString("/nonexistentdirectory"),
}
}

subpObj := &object.Object{
FieldTable: map[string]object.Field{
"commandLine": {Fvalue: []*object.Object{object.StringObjectFromGoString("ls"), object.StringObjectFromGoString("/nonexistentdirectory")}},
"commandLine": {Fvalue: cmdLine},
"classpath": {Fvalue: []*object.Object{}},
"stdout": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
"stderr": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
Expand All @@ -579,17 +616,32 @@ func TestJjSubProcess_ExitError(t *testing.T) {
params := []interface{}{subpObj}
exitCode := jjSubProcess(params)

// ls /nonexistentdirectory usually exits with 2
if exitCode == 0 {
t.Errorf("Expected non-zero exit code, got %v", exitCode)
}
}

func TestJjSubProcess_Classpath(t *testing.T) {
trace.Init()

// "env" prints the environment on POSIX.
// On Windows, "cmd.exe /C set" is the equivalent — it also outputs KEY=VALUE lines.
var cmdLine []*object.Object
if runtime.GOOS == "windows" {
cmdLine = []*object.Object{
object.StringObjectFromGoString("cmd.exe"),
object.StringObjectFromGoString("/C"),
object.StringObjectFromGoString("set"),
}
} else {
cmdLine = []*object.Object{
object.StringObjectFromGoString("env"),
}
}

subpObj := &object.Object{
FieldTable: map[string]object.Field{
"commandLine": {Fvalue: []*object.Object{object.StringObjectFromGoString("env")}},
"commandLine": {Fvalue: cmdLine},
"classpath": {Fvalue: []*object.Object{object.StringObjectFromGoString("test_cp")}},
"stdout": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
"stderr": {Ftype: types.ByteArray, Fvalue: []types.JavaByte{}},
Expand Down
Loading