Conversation
5b8b9a3 to
df3df79
Compare
sampullman
reviewed
Apr 6, 2026
|
@asimkhan73301 Do you remember why node_modules is committed here? My guess is that the intent is to avoid needing to cache when run by customers. |
Author
|
@sampullman I don't remember, bc this repo was created before I joined Plasmic, but I think I know. |
|
We can cache them, but I think there is a small downside since it's running on the user's action/job, so it will take up their cache quota. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sampullman the only thing i'm not sure in - can we also remove the node_modules commit as part of this PR?
I created a workflow file to properly cache the node_modules because i don't really like that changelogs are huge