Skip to content

[PLA-12591] node v24 support#8

Open
alex-noel wants to merge 2 commits intomasterfrom
PLA-12591/node-v20
Open

[PLA-12591] node v24 support#8
alex-noel wants to merge 2 commits intomasterfrom
PLA-12591/node-v20

Conversation

@alex-noel
Copy link
Copy Markdown

@sampullman the only thing i'm not sure in - can we also remove the node_modules commit as part of this PR?
I created a workflow file to properly cache the node_modules because i don't really like that changelogs are huge

@alex-noel alex-noel requested a review from sampullman April 6, 2026 14:29
@alex-noel alex-noel self-assigned this Apr 6, 2026
@alex-noel alex-noel force-pushed the PLA-12591/node-v20 branch from 5b8b9a3 to df3df79 Compare April 6, 2026 14:43
@sampullman
Copy link
Copy Markdown

@asimkhan73301 Do you remember why node_modules is committed here? My guess is that the intent is to avoid needing to cache when run by customers.

@alex-noel
Copy link
Copy Markdown
Author

@sampullman I don't remember, bc this repo was created before I joined Plasmic, but I think I know.
It's due to the way GitHub Actions used to work.
The intent was to avoid running npm install during every run, because there was no easy way to cache the modules.
I assume we can try caching those and removing them from the repo.
Though end users will not benefit from this (at all), it's just a tech debt

@sampullman
Copy link
Copy Markdown

We can cache them, but I think there is a small downside since it's running on the user's action/job, so it will take up their cache quota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants