Fix Folia task lifecycle during reload - #4
Open
Minecraft0122 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelAllKnownTasks()during reloadTimeAmount.ticksToMillisinstead of dividing ticks by 20Tests
JAVA_HOME=C:\Program Files\Java\jdk-21 ./gradlew :api:check :folia:check --rerun-taskspasses locallyContext
This moves the Folia scheduling portion of plan-player-analytics/Plan#4772 into PAL as requested by review. It addresses plan-player-analytics/Plan#4599 without adding a Plan-specific platform layer.
The repository-wide
checkcurrently stops in the untouched BungeeCord module becausenet.md-5:brigadier:1.0.16-SNAPSHOTis no longer resolvable; the affectedapiandfoliachecks pass.