Revise internal representation of Interface for Windows - #49
Open
nathaniel-bennett wants to merge 1 commit into
Open
nathaniel-bennett wants to merge 1 commit into
nathaniel-bennett wants to merge 1 commit into
Conversation
nathaniel-bennett
enabled auto-merge
February 14, 2025 04:28
nathaniel-bennett
force-pushed
the
interface-windows-fix
branch
from
February 14, 2025 04:30
a17eba0 to
94a0484
Compare
nathaniel-bennett
force-pushed
the
interface-windows-fix
branch
from
May 1, 2025 15:56
94a0484 to
1b9bf21
Compare
nathaniel-bennett
force-pushed
the
interface-windows-fix
branch
from
May 1, 2025 15:58
1b9bf21 to
83e6e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Interfaceis represented as an array ofu16values. This unfortunately does not work very well with certain methods that expect a short char representation of an interface name rather than wide char. SinceOsStrcan be constructed directly from the short char representation, and since it can form the wide char representation directly as needed, we'll opt to make the internal a short char for now.