-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(install): fix unsafe install script (args passing) #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rajdeep Malakar <rajdeepm.dev@gmail.com>
Pull Request Test Coverage Report for Build 12028820129Details
💛 - Coveralls |
jhheider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shell splitting is the worst. Will this work with spaces in arguments, or does the code really need to use an array?
Well, if you pass something like: pandoc file.md -thtmlUsing quotes will make it: So, it wouldn't work. Without So, yeah. It'll work with spaces in arguments with this solution, I suppose. |
b806c04 to
7c34462
Compare
|
If you want to install stubs we made a mash script where maybe this can go instead: https://github.com/pkgxdev/mash/blob/main/scripts/stub.sh |
|
We could still merge this into the |
Then I'll create a PR for the v1 branch, since it's sorta a bug on that one. |
By the way, I can't find the |
|
i don't believe one exists. there is a |
|
sorry, here: https://github.com/pkgxdev/pkgx/tree/v1/main |
The unsafe install thing (that was added recently), creates a bit different script as you know.
Well, in that, the args that you pass to the program were being passed as a single argument (
"$ARGS"). So, here's the simple one-line solution.cc @jhheider