Repository navigation
Conversation
The hire spot judged the portal ground from a guessed z (a GM teleport, climb or landing leaves session.StatusInfo.ZUnknown until the server sends a position), so a guess could pass the drop check. AgentPosition now returns whether z is the server's own; the step waits up to 10 s for it near the portal and refuses with "hire: commander height unknown near the portal" when it never arrives. Far from the portal an unknown height is not judged.
…oor (#266) The hire spot compares the navmesh floor under the commander with the navmesh floor under the portal point instead of the guessed height against the trigger centre, so a trigger a few yards above the ground no longer refuses a commander standing on it, and the 10 s height wait is gone. A kept binding that already holds the wanted party is not checked: a resume hires nothing new there. The plan's tank_min_hp is set at the band's middle level; the preflight scales it to the hired tank's own level with the 2026-10 test runs' per-level health curve, rounded down to 50.
… assumes tier gear
…lk is floor-checked The settle walk for a guessed height over two floors tried a 3 yd step east first, and a step that left the 15 yd portal radius passed the hire as allowed without the portal-ground floor check. The walk now picks only targets inside the radius, the one nearest the portal first, and a settled height is judged on its floor wherever the walk ended.
Owner
Author
|
Combined into #401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266 (the hire preflight).
What changes
tank_min_hp, derived from measured tank HP (~/TortoiseBots-audit/specs/ta-266-data/tanks.tsv) at the band's middle level. The check scales it to the hired tank's actual level with the same curve.team.Tests: the per-plan floor table (both directions); the level scaling (Maraudon Orange at level 45); the WC, ST and DM East real ground samples (allowed); the RFC spot and the stacked guessed floor (refused); no navmesh; the team check; stop propagation.
Reviews: Codex (4 rounds) and an Opus cold review. The Opus findings (an unreachable height wait, the trigger-centre reference, the level scaling) are fixed. Where Codex and Opus disagreed, the lead decided: lowest floor for a guessed height.