Skip to content

Disable script critic for music videos to preserve song timing - #391

Merged
pizzato merged 1 commit into
mainfrom
codex/disable-music-video-script-critic
Sep 15, 2026
Merged

pizzato merged 1 commit into
mainfrom
codex/disable-music-video-script-critic

Conversation

@pizzato

@pizzato pizzato commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Summary

The script critic could delete or reorder music-video scenes after their song windows were assigned. Final assembly still played the uninterrupted song, putting otherwise synchronized takes against the wrong audio. In “The Year I Forgot How to Fall,” critic deletions moved scene 3 ten seconds ahead of its intended song window.

Skip automatic script criticism for music videos, reject manual critic runs, and disable the critic controls in the editor. Update the documentation and automation setting text to describe the exception. The separate lyrics critic remains available before song generation.

This prevents new critic damage; it does not repair existing affected films.

Validation

  • 208 tests passed across test_story_endpoints.py, test_automation_song.py, and test_performance_pathway.py, including regression coverage for skipped automatic passes and blocked manual runs preserving script/history.
  • ruff check . and git diff --check passed.
  • Frontend production build passed with npm run build -- --configLoader native.
  • Browser verification confirmed the music-video critic button and pass selector are disabled with the timing explanation.

@pizzato
pizzato merged commit d642646 into main Sep 15, 2026
5 checks passed
@pizzato
pizzato deleted the codex/disable-music-video-script-critic branch September 15, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant