Disable script critic for music videos to preserve song timing - #391
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The script critic could delete or reorder music-video scenes after their song windows were assigned. Final assembly still played the uninterrupted song, putting otherwise synchronized takes against the wrong audio. In “The Year I Forgot How to Fall,” critic deletions moved scene 3 ten seconds ahead of its intended song window.
Skip automatic script criticism for music videos, reject manual critic runs, and disable the critic controls in the editor. Update the documentation and automation setting text to describe the exception. The separate lyrics critic remains available before song generation.
This prevents new critic damage; it does not repair existing affected films.
Validation
test_story_endpoints.py,test_automation_song.py, andtest_performance_pathway.py, including regression coverage for skipped automatic passes and blocked manual runs preserving script/history.ruff check .andgit diff --checkpassed.npm run build -- --configLoader native.