feat: Burst photos toggle in photo backup#157
Closed
ihmpavel wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a user-facing toggle to control whether Photo Backup includes every frame from iOS Burst sequences, and wires that setting into the Photos fetch so burst frames can be exported.
Changes:
- Add a “Burst photos (include all frames)” toggle to Photo Backup settings and reset the persistent change token when it changes.
- Persist the burst-inclusion setting via
@AppStorageand apply it toPHFetchOptions.includeAllBurstAssets. - Refactor some path variables during export (
inFolderPath→destinationPath) and adjust related logging / bookkeeping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Sushitrain/PhotoBackupView.swift |
Adds the new burst toggle UI and resets the change token when toggled. |
Sushitrain/PhotoBackup.swift |
Persists the new setting, applies it to the Photos asset fetch options, and refactors destination-path handling in the export loop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks! I was actually working on this as well right now, so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photo backup does not include all photos taken in Burst mode.
Fixes #156
Parts of the changes in
PhotoBackup.swift, specifically aroundinFolderPath, were edited with the help of an AI agent. You can take over this PR or tell me to revert them.Before merging please try to test the changes made in this PR as I do not know all the edge-cases.
Feel free to cherry-pick, take over or close this PR.