Fix websocket reconnect state timing#1391
Open
0xgeorgemathew wants to merge 1 commit intopingdotgg:mainfrom
Open
Fix websocket reconnect state timing#13910xgeorgemathew wants to merge 1 commit intopingdotgg:mainfrom
0xgeorgemathew wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Updated the web socket transport to report
reconnectingas soon as a reconnect attempt is scheduled, instead of waiting until the next socket attempt starts.Added a regression test covering the backoff window after a socket close.
Why
After a socket close, the transport scheduled a reconnect timer but kept reporting
closeduntil the timer fired. That made the transport state inaccurate during reconnect backoff.This keeps the state machine aligned with the actual retry lifecycle without changing transport behavior beyond the reported state.
Checklist
Note
Low Risk
Low risk: changes only the reported
WsTransportstate during reconnect backoff and adds a regression test; no protocol, request handling, or retry timing behavior changes.Overview
Updates
WsTransportto switch toreconnectingimmediately when a reconnect timer is scheduled (instead of remainingcloseduntil the nextconnect()call).Adds a Vitest regression test using fake timers to assert the transport reports
reconnectingright after a socket close and before the next WebSocket attempt is created.Written by Cursor Bugbot for commit 63c72b9. This will update automatically on new commits. Configure here.
Note
Fix
WsTransportto report 'reconnecting' state immediately when reconnect is scheduledPreviously,
WsTransport.getState()would not return'reconnecting'until a later phase of the reconnect flow. Nowthis.stateis set to'reconnecting'at the start ofscheduleReconnect(), before the delay is calculated and the timeout is set. A new test in wsTransport.test.ts uses fake timers to assert the state is correct immediately after socket close.Macroscope summarized 63c72b9.