fix(web): clear composer border after picker dismissal#1382
Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom Mar 26, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Abdulelah Hajjar <aab.hajjar@gmail.com>
d1b2eed to
d7aabab
Compare
aaditagrawal
pushed a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 26, 2026
Merged
7 tasks
kkorenn
pushed a commit
to kkorenn/k1code
that referenced
this pull request
Mar 26, 2026
apexsloth
pushed a commit
to apexslothforks/t3code
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Replaced
focus-within:border-ring/45withhas-focus-visible:border-ring/45on the composer container inChatView.tsx.Why
The composer border highlights when the editor is active using
focus-within, which maps to CSS:focus-within. This works well for the editor itself but it also activates when toolbar buttons (like the model or effort picker) receive focus. So if a user opens a picker and then clicks outside to dismiss it, the blue border can stick around since focus remains on the trigger button.Swapping to
has-focus-visible(css:has(:focus-visible)) narrows this to keyboard-intent focus only. Buttons clicked with a mouse aren't marked as focus-visible, which avoids the border staying after dismissal. Clicking into the editor still shows the border since browsers treat editable elements as focus-visible.UI Changes
Before
Before.mp4
After
After.mp4
Checklist
Note
Low Risk
Low risk UI-only styling change that alters when the composer shows its focus border; main risk is inconsistent
:has(:focus-visible)support or unintended focus styling regressions across browsers.Overview
Updates the chat composer container styling in
ChatView.tsxto usehas-focus-visible:border-ring/45instead offocus-within:border-ring/45, so the blue border highlight only appears for keyboard-visible focus and clears when pickers/toolbar buttons are dismissed via pointer.Written by Cursor Bugbot for commit d7aabab. This will update automatically on new commits. Configure here.
Note
Fix composer border highlight to clear on picker dismissal in
ChatViewChanges the Tailwind variant on the composer container in ChatView.tsx from
focus-within:border-ring/45tohas-focus-visible:border-ring/45. This ensures the border highlight only appears when a descendant has keyboard-visible focus, so it clears correctly when a picker (e.g. emoji picker) is dismissed via pointer.Macroscope summarized d7aabab.