Skip to content

tests: rebalance heavy integration test groups #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tenfyzhong wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: rebalance heavy integration test groups #4256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/integration_tests/run_heavy_it_in_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ mysql_groups=(
# G00
'api_v2 generate_column many_pk_or_uk multi_source'
# G01
'ddl_for_split_tables_with_random_move_table'
'ddl_for_split_tables_with_random_move_table syncpoint_check_ts random_drop_message'
# G02
'ddl_for_split_tables_with_failover'
'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling '
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove trailing space to avoid an empty test token.

The trailing space in the group string can yield an empty case name depending on how run.sh splits the list; safer to trim it. Line 37.

🧹 Proposed fix 
-'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling '
+'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling '
'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling'
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@tests/integration_tests/run_heavy_it_in_ci.sh` at line 37, The test-group
string contains a trailing space in the token list
('ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ')
which can produce an empty test name when split; remove the trailing space (or
trim the variable) so the value becomes 'ddl_for_split_tables_with_failover
in_flight_syncpoint_during_scheduling' (or call a trim on the variable before
splitting) to avoid emitting an empty test token.

Copy link

@gemini-code-assist gemini-code-assist bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a trailing whitespace at the end of this line. While it might not cause issues with the current script logic, it's best to remove it for code cleanliness and to prevent potential parsing problems in the future.

Suggested change
'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling '
'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling'

# G03
'cdc move_table in_flight_ddl_during_scheduling checkpoint_race_ddl_crash'
# G04
'complex_transaction'
# G05
'ddl_for_split_tables_with_merge_and_split syncpoint in_flight_syncpoint_during_scheduling syncpoint_check_ts random_drop_message'
'ddl_for_split_tables_with_merge_and_split syncpoint'
# G06
'ddl_for_split_tables_with_random_merge_and_split'
# G07
Expand Down
Loading