Conversation
Member
|
16 is an arbitrary pin, if we want to support long/short presses it should probably be across all inputs and possible to specify in the config somehow. This library sorely needs refactoring to use libgpiod, though, so perhaps that should be tackled first! Great idea in theory, though, sorry for the delayed response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for the Raspberry GPIO Frontend. It modifies the button event handling logic for Pin 16 as follows:
This logic ensures that only one event is triggered based on the duration of the button press, preventing multiple events from disturbing the playlist.
Changes Made
Important! Make sure Mopidy or mpc has repeat off, otherwise you don't go previous but to start of song.