Repoint static analysis to reusable-static-analysis-unified - #93
Merged
Merged
Conversation
berfinyuksel
added
the
Skip Milestone Check
There was a problem hiding this comment.
Pull request overview
Reactivates static analysis by migrating to the unified reusable workflow.
Changes:
- Generates and passes the unified PHPStan matrix.
- Adds scoped triggers, path exclusions, and concurrency cancellation.
- Updates required inputs and secrets.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| phpstan_matrix: ${{ needs.setup-matrix.outputs.phpstan_matrix }} | ||
| private_repo: ${{ needs.setup-matrix.outputs.private_repo }} | ||
| APP_ENV: test | ||
| PIMCORE_TEST: 1 |
Rebased to 2.3 per the platform-version line map (2024.4/2025.4/2026.2/2026.x are the valid lines; the previous base was not on a valid line). The caller referenced a reusable retired on 2025-12-09, so every run start-failed with zero jobs. Convergence lands on the 2025-line only; 2024-line workflows keep their own matrices per policy. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
berfinyuksel
force-pushed
the
ci/static-analysis-unified-2.0
branch
from
August 26, 2026 14:14
77ed3d5 to
a912e09
Compare
DevOps-Tasks#44 / prep for stacked PRs (DevOps-Tasks#48): pull_request base-branch filter so mid-stack PRs (base = another feature branch) skip the heavy suites. Normal PRs target version branches and are unaffected. No required checks gate these workflows (verified). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Per review: identical workflows must look identical unless there is a reason not to. pull_request runs for every base branch again (developers expect the suites on PRs from any branch name); push stays scoped to version branches; every job timeout is uniformly 30 minutes; concurrency is uniformly keyed by PR number. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
An unscoped push trigger runs on every branch push - the opposite of DevOps-Tasks#44 idea 1. Scoping restored (original list for pre-existing files, version branches for the modernized static analysis). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Per review of the drift map: .bak files removed, obsolete frontend/npm workflows removed, cla/docs/poeditor/cs-fixer/copilot-setup/stale synced to the 2026.x content and filenames, and static analysis gets the uniform paths-ignore (assets, assets-customized, doc, install, src/Resources/public, **.md). Matrix-bearing workflows keep their era-specific content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the silently-dead static analysis (pimcore/DevOps-Tasks#47): this branch's caller references
reusable-static-analysis-centralized.yaml, retired from workflows-collection-public on 2025-12-09 — every run since start-failed with zero jobs. Replaced with the unified pattern validated on pimcore/web2print-tools#121 and green on pimcore/system-info-bundle#61 / pimcore/opensearch-client#59.This lands on the lowest 12-era branch: the older branches of this repo cannot install any Pimcore ^10/^11 release under Composer 2.9's Packagist advisory policy (verified in PR runs), so their static analysis stays documented on #47 pending the workflows-owner decision. Forward-merge up the remaining chain follows after merge.
Also carries pimcore/DevOps-Tasks#44 ideas 1–3 in the same file: push scoped to version branches,
concurrencykeyed by PR number (cancels superseded runs, no cross-fork collisions), paths-ignore for docs/assets/markdown.Expected on this PR: static analysis runs real matrix legs.