Repoint static analysis to reusable-static-analysis-unified - #83
Conversation
berfinyuksel
added
the
Skip Milestone Check
There was a problem hiding this comment.
Pull request overview
Reactivates static analysis by migrating to the unified reusable workflow and refining workflow triggers.
Changes:
- Uses the unified PHPStan matrix workflow.
- Adds path filters and version-branch push restrictions.
- Adds cancellation of superseded runs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| needs: setup-matrix | ||
| uses: pimcore/workflows-collection-public/.github/workflows/reusable-static-analysis-unified.yaml@main | ||
| with: | ||
| phpstan_matrix: ${{ needs.setup-matrix.outputs.phpstan_matrix }} |
Rebased to 2.1 per the platform-version line map (2024.4/2025.4/2026.2/2026.x are the valid lines; the previous base was not on a valid line). The caller referenced a reusable retired on 2025-12-09, so every run start-failed with zero jobs. Convergence lands on the 2025-line only; 2024-line workflows keep their own matrices per policy. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
c8102e8 to
bc29b2d
Compare
|
Converting to draft: the repoint itself works (setup-matrix and both legs execute), but the restored analysis surfaces real PHPStan findings on 2.1 that were invisible while the workflow was dead — e.g. scalarNode() on the unknown generic NodeBuilder class under highest deps. Needs either a phpstan-baseline entry or the small Configuration type-hint fix on this branch before merge; that is a code decision, not a workflow one. Marking draft so nobody merges a permanently-red check. |
Per review of the drift map: .bak files removed, obsolete frontend/npm workflows removed, cla/docs/poeditor/cs-fixer/copilot-setup/stale synced to the 2026.x content and filenames, and static analysis gets the uniform paths-ignore (assets, assets-customized, doc, install, src/Resources/public, **.md). Matrix-bearing workflows keep their era-specific content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Fix for the silently-dead static analysis (pimcore/DevOps-Tasks#47): this branch's caller references
reusable-static-analysis-centralized.yaml, retired from workflows-collection-public on 2025-12-09 — every run since start-failed with zero jobs. Replaced with the unified pattern validated on pimcore/web2print-tools#121 and green on pimcore/system-info-bundle#61 / pimcore/opensearch-client#59.This lands on the lowest 12-era branch: the older branches of this repo cannot install any Pimcore ^10/^11 release under Composer 2.9's Packagist advisory policy (verified in PR runs), so their static analysis stays documented on #47 pending the workflows-owner decision. Forward-merge up the remaining chain follows after merge.
Also carries pimcore/DevOps-Tasks#44 ideas 1–3 in the same file: push scoped to version branches,
concurrencykeyed by PR number (cancels superseded runs, no cross-fork collisions), paths-ignore for docs/assets/markdown.Expected on this PR: static analysis runs real matrix legs.