Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err := cataloguePins.Refresh(); err != nil { | ||
| if cataloguePins.LoadCache() { | ||
| log.Printf("appstore: catalogue refresh failed (%v); using %d cached publisher pin(s)", err, cataloguePins.Count()) | ||
| slog.Warn(fmt.Sprintf("appstore: catalogue refresh failed (%v); using %d cached publisher pin(s)", err, cataloguePins.Count())) |
| } | ||
| } else { | ||
| log.Printf("appstore: loaded %d catalogue publisher pin(s)", cataloguePins.Count()) | ||
| slog.Info(fmt.Sprintf("appstore: loaded %d catalogue publisher pin(s)", cataloguePins.Count())) |
TeoSlayer
force-pushed
the
fix/quiet-startup-logs
branch
from
October 8, 2026 13:41
e7a4639 to
673e30e
Compare
…evel - The tunnel binding every interface is what a node does, not a warning; it fired on every start of every default install, with a hint (-listen 127.0.0.1:0) that would cut the node off. - Pass the daemon's slog logger to the app store (Config.Slog, app-store v1.0.7), so its lines are INFO or WARN like the rest of the log; through its default log.Logger they had no level and the Mac app counted all of them as warnings. Skipped install-root dirs are logged once. - The catalogue pin lines go through slog too: a failed refresh at start is a warning; the 10-minute refresh failing while offline is INFO. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TeoSlayer
force-pushed
the
fix/quiet-startup-logs
branch
from
October 8, 2026 14:52
673e30e to
af1dd97
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Mac, in under an hour, the daemon's log held 1,574 copies of
appstore skip io.pilot.wallet: read manifest: … no such file or directory. The Mac app listed it as the top "warning the daemon repeats", along with two more routine lines.Fix
The app store's lines carry a level.
Config.Slog(app-store v1.0.7, bumped here).log.Loggerthey had no level, and the Mac app counts every level-less line as a warning.tunnel bound to wildcard addressis gone.-listen 127.0.0.1:0, would cut the node off.tunnel listeningline.The catalogue pin lines go through slog.
Tests
go build ./...andgo vetpass.go test -race ./cmd/... ./internal/... ./pkg/...passes../testsshows dial and datagram timeouts on this machine right now. They come from contention: a parallel soak test and post-reboot indexing. The same tests fail the same way on main without this change (checked against the commit before #510).🤖 Generated with Claude Code