Skip to content

pilotctl: justify the five gosec findings introduced by #490 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
Oct 7, 2026
Merged

pilotctl: justify the five gosec findings introduced by #490 #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmd/pilotctl/appstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ func cmdAppStoreInstall(args []string) {
// The bundle was unpacked into a temporary directory for this
// install alone. It was never removed, so every install — failed or
// not — left a copy of the app behind in $TMPDIR.
removeUnpacked := func() { _ = os.RemoveAll(bundleDir) }
removeUnpacked := func() { _ = os.RemoveAll(bundleDir) } // #nosec G703 -- for a catalogue install bundleDir is the os.MkdirTemp directory fetchAndUnpackBundle created; never a caller-supplied path
defer removeUnpacked()
fatalCleanups = append(fatalCleanups, removeUnpacked)
}
Expand Down Expand Up @@ -2687,7 +2687,7 @@ func cmdAppStoreCall(args []string) {
}
}
}
if _, serr := os.Stat(filepath.Join(appDir, ".suspended")); serr == nil {
if _, serr := os.Stat(filepath.Join(appDir, ".suspended")); serr == nil { // #nosec G703 -- only a stat of a fixed name under the app dir the operator named; nothing is read or written
fatalHint("io_error",
"the app crashed repeatedly and was suspended: `pilotctl appstore audit "+appID+"` shows the exits, the app's own error output is in the daemon's log; `pilotctl appstore restart "+appID+"` retries it",
"app %s is suspended", appID)
Expand Down Expand Up @@ -2814,14 +2814,14 @@ const appSocketWait = 15 * time.Second
func waitForAppSocket(appDir, sockPath string, wait time.Duration) error {
deadline := time.Now().Add(wait)
for {
_, err := os.Stat(sockPath)
_, err := os.Stat(sockPath) // #nosec G703 -- only a stat of app.sock under the app dir the operator named; nothing is read or written
if err == nil {
return nil
}
if _, merr := os.Stat(filepath.Join(appDir, "manifest.json")); merr != nil {
if _, merr := os.Stat(filepath.Join(appDir, "manifest.json")); merr != nil { // #nosec G703 -- only a stat of a fixed name under the app dir; nothing is read or written
return err // not installed
}
if _, serr := os.Stat(filepath.Join(appDir, ".suspended")); serr == nil {
if _, serr := os.Stat(filepath.Join(appDir, ".suspended")); serr == nil { // #nosec G703 -- only a stat of a fixed name under the app dir; nothing is read or written
return err
}
if time.Now().After(deadline) {
Expand Down
Loading