Repository navigation
publish: pointer apps keep their store listing; PR text lists the platforms - #132
Merged
Merged
Conversation
…tforms publish-submission.sh looked for the submission's metadata.json by a path relative to the app-template checkout, after cd'ing into the platform clone, so it never found it: every pointer app was published with a bare entry (no display name, vendor, categories, license, source or metadata page). Wallet 0.4.0's catalogue PR (pilotprotocol#529) lost all of them. The path is now absolute. Both publish scripts built the PR's platform list with escaped quotes inside $(...), a jq syntax error; the list is now computed first. TestPublishSubmissionKeepsTheStoreListing runs the real script with gh and git push faked. It needs bash 4+ (mapfile), so it skips on macOS's bash 3.2 and runs on CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
publish-submission.shlooked for the submission'smetadata.jsonby a path relative to the app-template checkout. It looked aftercd'ing into the platform clone, so it never found the file. Every pointer app was published with a bare catalogue entry: no display name, vendor, categories, license, source or metadata page. Wallet 0.4.0's catalogue PR (pilotprotocol#529, closed) lost all of them.$(...). That is a jq syntax error, so the list came out empty.Fix
cd.gh pr create.Test
TestPublishSubmissionKeepsTheStoreListingruns the real script on a two-platform pointer submission, from the repo root with a relative dir as publish-on-merge does, withghandgit pushfaked. It checks:metadata_sha256against the publishedmetadata.json;It fails on main, on both bugs, and passes with the fix: run in a golang container. The script needs bash 4+ (
mapfile), so the test skips on macOS's bash 3.2 and runs on CI.🤖 Generated with Claude Code