Skip to content

publish: pointer apps keep their store listing; PR text lists the platforms - #132

Merged
TeoSlayer merged 1 commit into
mainfrom
fix/publish-metadata-path
Oct 8, 2026
Merged

TeoSlayer merged 1 commit into
mainfrom
fix/publish-metadata-path

Conversation

@TeoSlayer

Copy link
Copy Markdown
Contributor

Problem

  • publish-submission.sh looked for the submission's metadata.json by a path relative to the app-template checkout. It looked after cd'ing into the platform clone, so it never found the file. Every pointer app was published with a bare catalogue entry: no display name, vendor, categories, license, source or metadata page. Wallet 0.4.0's catalogue PR (pilotprotocol#529, closed) lost all of them.
  • Both publish scripts built the PR's "Platforms:" list with escaped quotes inside $(...). That is a jq syntax error, so the list came out empty.

Fix

  • The metadata path is absolute, resolved before the cd.
  • The platform list is computed before gh pr create.

Test

TestPublishSubmissionKeepsTheStoreListing runs the real script on a two-platform pointer submission, from the repo root with a relative dir as publish-on-merge does, with gh and git push faked. It checks:

  • the entry's listing fields;
  • metadata_sha256 against the published metadata.json;
  • the publisher pin and both bundles;
  • the PR's platform list.

It fails on main, on both bugs, and passes with the fix: run in a golang container. The script needs bash 4+ (mapfile), so the test skips on macOS's bash 3.2 and runs on CI.

🤖 Generated with Claude Code

…tforms

publish-submission.sh looked for the submission's metadata.json by a
path relative to the app-template checkout, after cd'ing into the
platform clone, so it never found it: every pointer app was published
with a bare entry (no display name, vendor, categories, license, source
or metadata page). Wallet 0.4.0's catalogue PR (pilotprotocol#529) lost
all of them. The path is now absolute.

Both publish scripts built the PR's platform list with escaped quotes
inside $(...), a jq syntax error; the list is now computed first.

TestPublishSubmissionKeepsTheStoreListing runs the real script with gh
and git push faked. It needs bash 4+ (mapfile), so it skips on macOS's
bash 3.2 and runs on CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TeoSlayer
TeoSlayer merged commit c469cb1 into main Oct 8, 2026
6 checks passed
@TeoSlayer
TeoSlayer deleted the fix/publish-metadata-path branch October 8, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant