supervisor: real daemon address for apps; pick up same-version rebuilds

[Alexgodoroja]

Two supervisor bugs found during the app-store audit. Both reproduce on real nodes (macOS plus linux amd64/arm64 VMs).

1. Every app gets the sentinel address

On a real node, wallet.address returns 0:0001.0000.0000, the supervisor's non-routable sentinel.

daemonAddrFromDeps asserts deps.Identity to interface{ Address() string }, but coreapi.Identity.Address() returns protocol.Addr (a struct with String()). The assertion never matches in the daemon, so every supervised app, and every wallet on the network, starts with --addr 0:0001.0000.0000.

Fix: look Address up by name via reflection (the module still doesn't import coreapi), and use the result if it is a string or a fmt.Stringer. Anything else falls back to the sentinel.

• TestDaemonAddrFromDeps_CoreapiIdentityAddress mirrors protocol.Addr's shape and formatting (fails before, passes after).
• TestDaemonAddrFromDeps_UnusableAddressMethodFallsBack checks there's no panic on an odd Address method.

2. A rebuilt bundle at the same version gets the app suspended

pilotctl appstore upgrade reinstalls a rebuilt bundle at the same version ("rebuilt (same version, new bundle)"). rescanForNew skipped any manifest whose app_version matched, so the supervisor kept verifying the new binary against the old pin until it hit sha256 mismatch … >=10 consecutive verify failures and suspended the app. appstore restart reused the same stale manifest, so only a daemon restart recovered. Seen on the audit VMs with rebuilt cosift 0.1.3 / wallet 0.3.4 bundles.

Fix: a same-version manifest with a different binary.sha256 is swapped in like an upgrade. The old supervise goroutine is cancelled, the crash record and .suspended marker are cleared, and a rebuild-applied audit event is written.

• TestRescanAppliesSameVersionRebuild fails before, passes after.

Tests

go test ./... is green except TestReapStaleKillsEveryInstance. That test is flaky on untouched main too (fails with -count=5 on main, 5/5 passes on this branch) and is unrelated.

Rollout

Ships to nodes through a pilotprotocol daemon release that bumps github.com/pilot-protocol/app-store.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
plugin/appstore/supervisor.go	90.90%	2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!