Hello, macOS 👋 (& system-supplied playback controls)#181
Hello, macOS 👋 (& system-supplied playback controls)#181chriszielinski wants to merge 62 commits intopiemonte:mainfrom
Conversation
|
hey, greatly appreciate the contributions. i typically prefer smaller PR's but i'll have to go through this and @addbrick contributions. i also need to split out the newer swift version changes to a new branch. |
|
Is there a reason this never got merged? I actually misunderstood the purpose of this entire library and when it said "customizable UI and user interaction" I figured it would have nice default custom video playback controls, and that I'd be able to extend those to fit my needs. This seems like the main value add of a custom video player, no? Since this is so old and has tons of conflicts now, I'm not planning to reply on this being merged any time soon. Do any of you know of alternative packages that offer custom video controls without needing to use |
Still needs
AVPlayerViewControllerimplementation can be cleaned up. The double nested view controllers rub me the wrong way.Thoughts? Comments? Concerns?