FNSR ExpressionResultStorage #4628
Open
+2,151
−472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
fnsr-storage
branch
4 times, most recently
from
c0b8d16 to
8e54658
Compare
Contributor
|
issue bot results look outstanding - too good to be real 🥸 |
Member
Author
|
Lots of diffs doesn't mean lots of bugs fixed 😀 The analysis is still too wrong. |
…ions to Scope debug
…lready stored expr result
ondrejmirtes
force-pushed
the
fnsr-storage
branch
from
8e54658 to
98587b0
Compare
ondrejmirtes
force-pushed
the
fnsr-storage
branch
from
01dfbcf to
895ce9e
Compare
…when FNSR is enabled)
ondrejmirtes
force-pushed
the
fnsr-storage
branch
from
895ce9e to
412cc4e
Compare
Member
Author
|
Alright, so this issue-bot report is far more realistic and closer to the end results. Solving issues like https://phpstan.org/r/8d3536cc-d647-455c-8919-300cc35d7abf and https://phpstan.org/r/59b9367b-8f29-4008-8536-91dca00362df is what I had in mind. |
Member
Author
|
I’m sure it’s used. It overrides an empty method from NodeScopeResolver.
Ondřej Mirtes
…On Fri 19. 12. 2025 at 7:30, Markus Staab ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Analyser/Fiber/FiberNodeScopeResolver.php
<#4628 (comment)>:
> + $request->scope->toMutatingScope(),
+ $storage,
+ new NoopNodeCallback(),
+ ExpressionContext::createTopLevel(),
+ );
+ if ($storage->findResult($request->expr) === null) {
+ throw new ShouldNotHappenException(sprintf('processExprNode should have stored the result of %s on line %s', get_class($request->expr), $request->expr->getStartLine()));
+ }
+ $this->processPendingFibers($storage);
+
+ // Break and restart the loop since the array may have been modified
+ return;
+ }
+ }
+
+ protected function processPendingFibersForRequestedExpr(ExpressionResultStorage $storage, Expr $expr, ExpressionResult $result): void
this method seems unused
—
Reply to this email directly, view it on GitHub
<#4628 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZTOFVYCLK67LVP4DOC2L4COLQPAVCNFSM6AAAAACOW6DOEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOJXGA4DMMJXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
staabm
reviewed
Dec 19, 2025
| } | ||
| } elseif ($expr instanceof Expr\Empty_) { | ||
| $this->processExprNode($stmt, $expr->expr, $scope, $storage, new NoopNodeCallback(), $context->enterDeep()); |
Contributor
There was a problem hiding this comment.
why/which expressions need to be processed twice? I can see this only happens for a few ones
staabm
reviewed
Dec 19, 2025
| */ | ||
| public function cloneNode(Node $node): Node | ||
| { | ||
| $traverser = new NodeTraverser(new CloningVisitor()); |
Contributor
There was a problem hiding this comment.
I can see we sometimes clone nodes which have already been cloned.
(so we clone the clone)
it might make sense to prevent some unnecessary per node work on this area
Contributor
There was a problem hiding this comment.
it seems occasionally we even clone the cloned clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.