Skip to content

Hash group/stream name for creation cache item key #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajdinmore wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hash group/stream name for creation cache item key #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Handler/CloudWatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,11 @@ private function initializeGroup(): void
{
// Check if a PSR-6 cache pool is available
if ($this->cacheItemPool !== null) {
// Create a cache key based on the group name, use hash to avoid invalid characters
$cacheKey = 'cwh-group-' . hash('crc32c', $this->group);

// Attempt to retrieve the cached state for the current log group
$cacheItem = $this->cacheItemPool->getItem($this->group);
$cacheItem = $this->cacheItemPool->getItem($cacheKey);

// If the group is already cached, skip further initialization
if ($cacheItem->isHit()) {
Expand Down Expand Up @@ -377,10 +380,7 @@ private function initializeGroup(): void
}

// Check if a cache pool is configured
if ($this->cacheItemPool !== null) {
// Retrieve or create a cache item for the current log group
$cacheItem = $this->cacheItemPool->getItem($this->group);

if (isset($cacheItem)) {
// Mark the log group as initialized/existing
$cacheItem->set(true);

Expand All @@ -399,8 +399,11 @@ private function initializeStream(): void
{
// Check if a PSR-6 cache pool is configured
if ($this->cacheItemPool !== null) {
// Create a cache key based on the stream name, use hash to avoid invalid characters
$cacheKey = 'cwh-stream-' . hash('crc32c', $this->stream);

// Attempt to retrieve the cached state for the current log stream
$cacheItem = $this->cacheItemPool->getItem($this->stream);
$cacheItem = $this->cacheItemPool->getItem($cacheKey);

// If the stream is already known to exist in cache, skip initialization
if ($cacheItem->isHit()) {
Expand Down Expand Up @@ -435,10 +438,7 @@ private function initializeStream(): void
}

// If a cache pool is available, mark the log stream as initialized
if ($this->cacheItemPool !== null) {
// Create/retrieve a cache item using the stream name as the key
$cacheItem = $this->cacheItemPool->getItem($this->stream);

if (isset($cacheItem)) {
// Set value to true to indicate the stream exists
$cacheItem->set(true);

Expand Down