Skip to content

fix: break after finding ini comment #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g105b merged 2 commits into from
Jul 27, 2026
Merged

fix: break after finding ini comment #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55270a0
fix: break after finding ini comment
pixeldrift64 Jul 26, 2026
f31adc0
tweak: added test
pixeldrift64 Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CommentIni.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ private function findIniComment(iterable $walker):array {

$this->assertCommentIsLeadingNode($commentNode);
$commentNodeToRemove = $commentNode;
break;
}

return [$commentNodeToRemove, $ini];
Expand Down
7 changes: 7 additions & 0 deletions test/phpunit/CommentIniTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ public function testContainsIniData_emptyIfMalformedIniSyntax():void {
self::assertStringContainsString("something: broken", $document->saveHTML());
}

public function testContainsIniData_onlyFindsFirstComment():void {
$document = new HTMLDocument(HTMLPageContent::HTML_COMMENT_WITH_INI_AND_ANOTHER_COMMENT);
$sut = new CommentIni($document);
self::assertTrue($sut->containsIniData());
self::assertEquals("base-page", $sut->get("extends"));
}

public function testGet_noMatchingData():void {
$document = new HTMLDocument(HTMLPageContent::HTML_EXTENDS_PARTIAL_VIEW);
$sut = new CommentIni($document);
Expand Down
10 changes: 10 additions & 0 deletions test/phpunit/TestHelper/HTMLPageContent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,16 @@ class HTMLPageContent {
<article>
<h1>Hello from within a sub-template!</h1>
</article>
HTML;

const HTML_COMMENT_WITH_INI_AND_ANOTHER_COMMENT = <<<HTML
<!--
extends=base-page
-->
<article>
<!-- This is just another comment -->
<h1>Hello from within a sub-template!</h1>
</article>
HTML;

const HTML_COMPONENT = <<<HTML
Expand Down
Loading