curl: Deduplicate features array and fix coding style #20770
+88
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 23, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
MSTM but can you split the whitespace changes into a different commit that can be merged separately?
thg2k
force-pushed
the
pr/curl_cleanup
branch
from
75e306b to
3259696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8.4 there are two almost identical copies (minus the sentinel) of the features array.
Being an internal static array, there is no need for the sentinel, thus the related check inside the loop is no longer needed.
Simplifies the code, reduces the size of the compile product, and improves maintainability.
Also, some coding style fixes.