Open
Conversation
Author
|
Nico, this pull request fixes some major flaws in the original profile shift pull request. I did a lot more studying and thorough testing on this version. |
Author
|
Sorry, I thought that some files were not updated in the pull request but it seems to be OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finially found the time to correct the profile shift calculations. It is now working correctly as far as I could check it. (references to the checks are in the code to reproduce the results).
Positioning of gears has been added so that new gear nicely meshes with the selected gears. This can be done by selecting the master gear before you create a new gear or after you supplied the necessary input.
When selecting the master gear is selected before opening the addin, the main gear parameters are copied to the new gear. This allows you to do center to center positioning with profile shifting easily.