Skip to content

fix: patch generated web diagnostics#25

Merged
mattbaconz merged 1 commit into
mainfrom
release/v0.14.1
May 16, 2026
Merged

fix: patch generated web diagnostics#25
mattbaconz merged 1 commit into
mainfrom
release/v0.14.1

Conversation

@mattbaconz

Copy link
Copy Markdown
Contributor

Summary

  • fix Problems focus to show the changed excerpt for the verifier diagnostic file
  • normalize diagnostic paths like src/App.tsx:1:1 before generated-web retry policy extracts artifacts
  • make the local chess rules test seed runner-agnostic so it does not require a Vitest import
  • bump CLI/npm package metadata to v0.14.1 and add release notes

Verification

  • cargo fmt --all -- --check
  • cargo test --locked --workspace
  • cargo clippy --locked --workspace --all-targets -- -D warnings
  • cargo build --release --locked -p phonton-cli
  • target/release/phonton.exe version -> phonton 0.14.1
  • target/release/phonton.exe --help
  • npm run test:npm-wrapper
  • npm pack --dry-run

@mattbaconz mattbaconz merged commit a3a95df into main May 16, 2026
1 check passed
@mattbaconz mattbaconz deleted the release/v0.14.1 branch May 16, 2026 10:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15cd5eac5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread phonton-worker/src/lib.rs
Comment on lines +1137 to +1138
|| normalized.ends_with(".tsx")
|| normalized.ends_with(".jsx")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep fast-fail scoped to generated-app subtasks

The new artifact detector treats any diagnostic path ending in .tsx/.jsx as a generated-web artifact, so should_stop_before_generated_app_syntax_repair now fast-fails on first-attempt syntax errors even for non-generated React edits (for example, ordinary repo tasks that fail on src/App.tsx:1:1). That skips the normal repair retry loop and can prematurely fail user tasks that previously self-recovered.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant