!include/arch: use _PAGE_SIZE definition from p-r-kernel by oI0ck · Pull Request #486 · phoenix-rtos/libphoenix

oI0ck · 2026-06-22T11:13:58Z

JIRA: RTOS-1358

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: aarch64a53-zynqmp-qemu.

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
hal: move page size definitions to userspace accessible headers phoenix-rtos-kernel#800
jffs2: use PAGE_SIZE and PAGE_SHIFT definitions from libphoenix phoenix-rtos-filesystems#166
I will merge this PR by myself when appropriate.

gemini-code-assist

Code Review

This pull request introduces _PAGE_SHIFT and defines _PAGE_SIZE using bitwise shifts across various architectures, as well as exposing PAGE_SHIFT in limits.h. However, critical compilation errors were introduced in include/arch/ia32/arch.h and include/arch/riscv64/arch.h due to duplicated and nested macro definitions for SIZE_PAGE during the edits.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

github-actions · 2026-06-22T11:35:52Z

Unit Test Results

10 860 tests ±0 10 190 ✅ ±0 52m 27s ⏱️ - 1m 1s
670 suites ±0 670 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 32927ca. ± Comparison against base commit 7432e41.

♻️ This comment has been updated with latest results.

ziemleszcz · 2026-06-22T12:03:59Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces the _PAGE_SHIFT and PAGE_SHIFT macros across various architecture-dependent headers (including aarch64, armv7, armv8, ia32, riscv64, and sparcv8leon) and redefines _PAGE_SIZE using bitwise shifts. Additionally, it updates copyright years and author attributions in the modified files. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

julianuziemblo

_PAGE_SIZE, PAGE_SIZE, PAGESIZE and SIZE_PAGE are always defined the same way: _PAGE_SIZE = (1 << _PAGE_SHIFT), PAGE_SIZE = _PAGE_SIZE, PAGESIZE = _PAGE_SIZE and SIZE_PAGE = _Pragma(...) _PAGE_SIZE. Maybe we could transfer them to the common limits.h file that includes all those for different architectures? Or is there a reason this is kept separate?

anglov · 2026-06-22T17:21:32Z

As an author of deprecation message on macro SIZE_PAGE and C/POSIX orthodox I would suggest you to remove SIZE_PAGE macro with deprecation warning altogether - it's deprecated for literally 7 years, and system users had a time to switch to PAGE_SIZE or _PAGE_SIZE.

Exporting PAGE_SHIFT from limits.h is fishy – it's C/POSIX header so you shouldn't export additional macros from there. Maybe just leave _PAGE_SHIFT?

oI0ck · 2026-06-22T17:44:50Z

Exporting PAGE_SHIFT from limits.h is fishy – it's C/POSIX header so you shouldn't export additional macros from there. Maybe just leave _PAGE_SHIFT?

Sure, seems sane. <arch.h> is a thing, so there is no need really to export it in <limits.h>

oI0ck · 2026-06-22T17:53:00Z

Maybe we could transfer them to the common limits.h file that includes all those for different architectures? Or is there a reason this is kept separate?

I also thought about it, but OTOH, arch/* is very architecture specific. Making it adhere to an external header (by requiring arch/$ARCH/limits.h to define some macros), kind of rubs me the wrong way, even though it would work in most cases.

ziemleszcz · 2026-06-24T09:54:10Z

Consider adding PAGE_SHIFT define next to PAGE_SIZE define in arch limits.h headers for compatibility with Linux ports.

ziemleszcz · 2026-06-24T10:03:19Z


-#define _PAGE_SIZE 0x1000
-#define SIZE_PAGE  _Pragma("GCC warning \"'SIZE_PAGE' is deprecated. Use _PAGE_SIZE from arch.h or PAGE_SIZE from limits.h (POSIX only)\"") _PAGE_SIZE
+#define _PAGE_SHIFT 12


Consider using unsigned values everywhere, as done in the kernel:
#define _PAGE_SHIFT 12U
#define _PAGE_SIZE (1U << _PAGE_SHIFT)

oI0ck · 2026-06-24T12:00:21Z

Exporting PAGE_SHIFT from limits.h is fishy – it's C/POSIX header so you shouldn't export additional macros from there. Maybe just leave _PAGE_SHIFT?

Consider adding PAGE_SHIFT define next to PAGE_SIZE define in arch limits.h headers for compatibility with Linux ports.

Rabini sa niezdecydowani.

ziemleszcz · 2026-06-24T12:15:28Z

I understood that the idea is to use the PAGE_SIZE defined here for ports like JFFS2. JFFS2 also requires PAGE_SHIFT, though. I can agree that both should probably come from the kernel headers instead.

It has been deprecated some years already and it seems that there are not many places it is still used in. Deleted per deprecation message author suggestion. JIRA: RTOS-1356

This is already defined in <posix/limits.h> JIRA: RTOS-1358

oI0ck · 2026-06-29T14:12:30Z

I moved _PAGE_SIZE and _PAGE_SHIFT to the kernel in p-r-kernel#800. Changed the title and description accordingly.

Also, implemented changes suggested by @julianuziemblo regarding definition dedup.

JIRA: RTOS-1358

julianuziemblo

LGTM

oI0ck requested a review from a team June 22, 2026 11:13

github-actions Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread include/arch/ia32/arch.h Outdated

gemini-code-assist Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread include/arch/ia32/arch.h Outdated

Comment thread include/arch/riscv64/arch.h Outdated

oI0ck mentioned this pull request Jun 22, 2026

jffs2: use PAGE_SIZE and PAGE_SHIFT definitions from libphoenix phoenix-rtos/phoenix-rtos-filesystems#166

Merged

14 tasks

oI0ck force-pushed the michal.lach/page_shift branch from 618ab62 to cb0d310 Compare June 22, 2026 11:17

gemini-code-assist Bot reviewed Jun 22, 2026

View reviewed changes

oI0ck mentioned this pull request Jun 22, 2026

posix: implement POSIX semaphore interfaces #457

Draft

14 tasks

julianuziemblo reviewed Jun 22, 2026

View reviewed changes

oI0ck force-pushed the michal.lach/page_shift branch 2 times, most recently from 759b82d to 3af1b44 Compare June 23, 2026 08:29

oI0ck changed the title ~~include/arch: define _PAGE_SHIFT constant macro~~ !include/arch: define _PAGE_SHIFT constant macro Jun 23, 2026

oI0ck requested a review from a team June 23, 2026 09:49

ziemleszcz reviewed Jun 24, 2026

View reviewed changes

oI0ck force-pushed the michal.lach/page_shift branch 2 times, most recently from dc5cc96 to 0993310 Compare June 29, 2026 09:08

oI0ck requested review from julianuziemblo and ziemleszcz June 29, 2026 09:08

oI0ck force-pushed the michal.lach/page_shift branch 2 times, most recently from f707a88 to eb33f75 Compare June 29, 2026 13:22

oI0ck added 2 commits June 29, 2026 15:38

!include/arch: remove SIZE_PAGE macro

014e8e3

It has been deprecated some years already and it seems that there are not many places it is still used in. Deleted per deprecation message author suggestion. JIRA: RTOS-1356

include/arch: remove redundant _POSIX2_RE_DUP_MAX definition

6df3dae

This is already defined in <posix/limits.h> JIRA: RTOS-1358

oI0ck force-pushed the michal.lach/page_shift branch from eb33f75 to d29f889 Compare June 29, 2026 13:38

oI0ck changed the title ~~!include/arch: define _PAGE_SHIFT constant macro~~ !include/arch: use _PAGE_SIZE definition from p-r-kernel Jun 29, 2026

oI0ck mentioned this pull request Jun 29, 2026

hal: move page size definitions to userspace accessible headers phoenix-rtos/phoenix-rtos-kernel#800

Merged

14 tasks

oI0ck requested a review from anglov June 29, 2026 14:10

julianuziemblo reviewed Jun 30, 2026

View reviewed changes

Comment thread include/arch.h Outdated

include/arch: use _PAGE_SIZE from kernel headers

32927ca

JIRA: RTOS-1358

oI0ck force-pushed the michal.lach/page_shift branch from d29f889 to 32927ca Compare June 30, 2026 10:20

oI0ck requested a review from julianuziemblo June 30, 2026 10:31

julianuziemblo approved these changes Jun 30, 2026

View reviewed changes

oI0ck merged commit ca117cf into master Jun 30, 2026
47 checks passed

oI0ck deleted the michal.lach/page_shift branch June 30, 2026 10:53

Uh oh!

Conversation

oI0ck commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

ziemleszcz commented Jun 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

julianuziemblo left a comment

Choose a reason for hiding this comment

Uh oh!

anglov commented Jun 22, 2026

Uh oh!

oI0ck commented Jun 22, 2026

Uh oh!

oI0ck commented Jun 22, 2026

Uh oh!

ziemleszcz commented Jun 24, 2026

Uh oh!

ziemleszcz Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

oI0ck Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

oI0ck commented Jun 24, 2026

Uh oh!

ziemleszcz commented Jun 24, 2026

Uh oh!

oI0ck commented Jun 29, 2026

Uh oh!

Uh oh!

julianuziemblo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oI0ck commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading