Repository navigation
refactor: remove unnecessary complexity (ponytail review) - #27
Merged
Merged
Conversation
…lpers write_page now delegates to write_page_in_connection; session_title and _snippet each have one implementation; acknowledge_outbox_batch uses rowcount. Co-authored-by: Isaac <no-reply@databricks.com>
One write_page_in_connection call with shared kwargs, content_hash for run digests, and smaller router, evidence and gateway helpers. Co-authored-by: Isaac <no-reply@databricks.com>
Aliased SELECTs with one row helper, asdict for the batch digest, a shared archive_page helper, and a fixed RRF constant. Co-authored-by: Isaac <no-reply@databricks.com>
Drop four uncalled WikiClient methods, ignored search keywords, run_background_worker, the dotted env-key branch and the export --limit flag; map owned settings with a dict. Co-authored-by: Isaac <no-reply@databricks.com>
asdict for to_dict, next() for first-match scans, removesuffix for the .md path, and drop an unreachable bool branch. Co-authored-by: Isaac <no-reply@databricks.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary complexity found in a full-repo review. Every change preserves behavior; nothing user-facing changes except removing unused API surface.
Storage
SQLiteStore.write_pagedelegates towrite_page_in_connectioninstead of carrying a second copy of the version, chunk and outbox writes. It keeps its superseded-pageValueErrorand thebefore_commitfailpoint.session_titleand_snippeteach have one implementation (previously duplicated between the SQLite and PostgreSQL stores).acknowledge_outbox_batchreturnscursor.rowcount.Curation
_apply_patchbuildskwargsonce and makes one write call per store.content_hash.Remote
dataclasses.asdict; it is byte-identical because_jsonableserializes UUIDs asstr.archive_pagehelper replaces two copies.Unused surface removed
WikiClient.sync_index,index_row_count,reconcile_vs_sourceandlist_recent_by_cwd_tag, plus four ignoredsearchkeywords. No callers exist in the repo, hooks or scripts.run_background_worker, the dotted env-key branch, andexport_karpathy --limit.Stdlib
asdictforto_dict,next()for first-match scans, andremovesuffix.boolbranch.The work was done by GLM 5.3 Flash workers, one per file slice; I reviewed every diff and made small follow-up fixes.
Validation:
ruff check: clean.main).24 files changed, +157/−379.
This pull request and its description were written by Isaac.