Repository navigation
fix(curation): record the real author of applied curation changes - #23
Merged
Merged
Conversation
`_apply_patch` hard-coded `remote-curator` as the page-version author and link origin, so pages applied by the local curator were mislabelled. `apply_run` now takes `created_by` (default `remote-curator`, unchanged for remote runs, `sync apply` and conflict resolution); the local curator passes `local-curator`. Implemented by GLM 5.3 Flash; PostgreSQL tests rerun in review. Co-authored-by: Isaac <no-reply@databricks.com>
This was referenced Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_apply_patchhard-codedremote-curatoras thecreated_byof page versions (3 places) and as theoriginof inserted links (2 places, SQLite and PostgreSQL). Pages applied by the local curator (#21) were therefore labelled as remote.Change
apply_runtakescreated_by: str = "remote-curator"and passes it through_apply_groupand_apply_patchto all five places. The link origin is now a bound parameter.sync applyandresolve_conflict.run_curatorpassescreated_by="local-curator".Verification
created_by == "local-curator"and its link hasorigin == "local-curator". It failed before the change.remote-curatorfor a defaultapply_run.uv.lockis unchanged.GLM 5.3 Flash wrote the implementation. I reran the PostgreSQL tests outside its sandbox in review.
This pull request and its description were written by Isaac.