Add test:all script and isolate E2E on a dedicated port#28
Merged
Conversation
- New `test:all` script runs lint + typecheck + vitest + playwright in one command. - Playwright now always boots its own mock-backed server on port 3100 (`reuseExistingServer: false`) instead of reusing whatever is on the default port 3000. Previously a local `next dev` running against real Notion on :3000 would be reused by the E2E run, breaking the slug-based assertions; pinning a dedicated port makes E2E deterministic regardless of the local environment. - Update TESTING.md to document both changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Small follow-ups to the v5 test suite: adds a one-shot test:all script and isolates Playwright E2E onto a dedicated port (3100) with a fresh mock-backed server, preventing collisions with a local next dev running on :3000 against real Notion.
Changes:
- Adds
npm run test:allrunning lint → typecheck → vitest → playwright. - Pins Playwright to
npx next dev -p 3100withreuseExistingServer: falseandbaseURLhttp://localhost:3100. - Updates
TESTING.mdto describe the new script and port isolation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| v5/package.json | Adds test:all aggregate script. |
| v5/playwright.config.ts | Switches E2E to port 3100 and disables server reuse. |
| v5/TESTING.md | Documents the new script and port isolation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to the v5 test suite (#26):
npm run test:all— one command that runslint→typecheck→vitest→playwright.reuseExistingServer: false, instead of reusing whatever is on the default:3000.Why the port change
Previously, if you had
next devrunning locally on:3000against real Notion, Playwright'sreuseExistingServerwould grab that server instead of starting its own mock-backed one. The E2E specs assert slug-based URLs (/tools/form-4), so against real Notion's UUID slugs (/tools/35d90a97-…) they fail — a false negative that looks like a broken suite. Pinning a dedicated port + never reusing makes E2E deterministic regardless of the local dev environment, and leaves your:3000server untouched.Verification
npm run test:allrun locally with a real-Notion dev server still running on :3000:🤖 Generated with Claude Code