Repository navigation
heal: keep a heal when its line passes and the test then fails at a later locator - #26
Open
philmcneely wants to merge 2 commits into
Open
philmcneely wants to merge 2 commits into
philmcneely wants to merge 2 commits into
Conversation
…ater locator The re-run now returns its failure. When it stopped somewhere other than a line the patch wrote, the client reports failed_later with the redacted error and place, keeps the edit until the service answers and reverts unless it confirms. A heal kept for a later locator is followed by up to 3 more heals of the same test; a chain that ends unhealed marks the last kept heal still_failing and the PR body lists it for review.
…; a failing chained round is recorded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25.
When a heal's own line passes on re-run but the test fails on a later line, the client reports
failed_laterwith the redacted error, file, line and the re-run's stack (frames under the source roots, as in the request). The edit stays on disk until the service answers and is kept only onhealed.verify_runreturns(passed, failure);verify_passedwraps it.failedas before.later_locatoris followed by up to 3 more heals of the same test (LATER_ROUNDS). A chain that ends unhealed marks the last kept healstill_failing; the PR body lists those for review andheal-summary.jsoncounts them.chain_error) and the summary is still written. SIGTERM while an edit waits for the answer reverts it, as Ctrl-C already did.Needs the service change (heal-service
failed_later). Unit: 765 passed; ruff clean.