Conversation
phe-sto
requested changes
Dec 3, 2020
Owner
There was a problem hiding this comment.
python/enthic/ontology.py should not be modified.
Ontology.csv has to be suppressed.
Please merge master before further develop, in the mean time our friend Leonard changed extract_bundle and we don't want lose his job. Please see my remarks in the file.
phe-sto
requested changes
Dec 3, 2020
python/enthic/extract_bundle.py
Outdated
| from os.path import dirname, join, isdir | ||
| from re import sub, compile | ||
| from zipfile import ZipFile, BadZipFile | ||
| from .ontology import CODE, ONTOLOGY |
Owner
There was a problem hiding this comment.
It work fine but please use the package path import enthic.ontology ...
Collaborator
Author
There was a problem hiding this comment.
I will include the new variable CODE in bundle_extract directly
foundkim
force-pushed
the
Ontology
branch
2 times, most recently
from
38a0c4c to
8ca906a
Compare
phe-sto
requested changes
Dec 15, 2020
Owner
phe-sto
left a comment
phe-sto
left a comment
There was a problem hiding this comment.
The code variable will cause has many maintenance issues as the actual system.
The split(",") give a list.
| ACC_ONT[rows[3]]["bundleCodeAtt"].append( | ||
| {rows[1]: rows[2].split(",")} | ||
| ACC_ONT[ACCOUNTING[key][0]]["bundleCodeAtt"].append( | ||
| {ACCOUNTING[key]['code'][y][0]: str(code[ACCOUNTING[key]['code'][y][0]]).split(",")} |
Owner
There was a problem hiding this comment.
split(",") is not required anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.