fix: skip directory fsync for Windows moves - #170
Merged
Paul-Kyle merged 1 commit intoAug 31, 2026
Conversation
Member
|
This is complete, and the docstring is the reason I'm saying so. The old text claimed the destination directory is fsynced so the rename survives a crash — true before your change and false after it, and the easiest thing in the world to leave alone. You rewrote it to say where the fsync happens and what Windows gives up instead, and put the same note at the call site. A guarded call with a stale docstring above it would have been a worse bug than the one you fixed, because the next reader would trust it. The test also goes past its template: the write-side sibling only asserts the fsync was skipped, and yours checks the file actually moved and kept its contents. Merging. Thanks for a clean first contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168
Testing