Skip to content

refactor(frontend): harden log decryption against unhandled rejections #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omlahore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(frontend): harden log decryption against unhandled rejections #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions frontend/components/logs/SecretLogs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,38 @@ export default function SecretLogs(props: { app: string }) {

const envKeyPair = envKeys.find((envKey) => envKey.envId === event.environment.id)

const { publicKey, privateKey } = envKeyPair!.keys
// A log entry can reference an environment that no longer has a
// matching entry here, e.g. audit history retained for an
// environment the viewer has since lost access to or that was
// deleted. That is a real, expected case rather than a bug, so
// this must not be a non-null assertion: dereferencing undefined
// would throw inside this async function with nothing to catch
// it, an unhandled rejection.
if (!envKeyPair) {
console.error(
`No environment key available to decrypt log for environment ${event.environment.id}; leaving this entry undecrypted.`
)
return
}

const { publicKey, privateKey } = envKeyPair.keys

// Decrypt event fields
decryptedEvent!.key = await decryptAsymmetric(event!.key, privateKey, publicKey)
try {
// Decrypt event fields
decryptedEvent!.key = await decryptAsymmetric(event!.key, privateKey, publicKey)

setDecryptedEvent(decryptedEvent)
setDecryptedEvent(decryptedEvent)
} catch (error) {
console.error(`Failed to decrypt log for environment ${event.environment.id}:`, error)
}
}

if (log && envKeys.length > 0) decryptSecretEvent()
// envKeys is intentionally not a dependency: it is state on the
// enclosing SecretLogs component, so a change to it already re-renders
// this row with a fresh LogRow closure (LogRow is defined inside
// SecretLogs), which resets this effect regardless of its deps.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [log])

const relativeTimeStamp = () => {
Expand Down