-
Notifications
You must be signed in to change notification settings - Fork 34
Add new (helper) functions for proportions that prepares safe 2x2 cont. tables(s). #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Melkiades
merged 44 commits into
pharmaverse:main
from
wwojciech:1514_add_safe_2x2_table
Sep 17, 2026
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
9574799
Add new (helper) functions for proportions: assert_prop_data() and sa…
wwojciech 17965f0
Update man for assert_prop_data() and safe_2x2_table().
wwojciech 638b670
assert_prop_data() should not be exported.
wwojciech 1ab9c5f
assert_prop_data() man update.
wwojciech aac4af4
update assert_prop_data() man page.
wwojciech cfb01b2
Export assert_prop_data().
wwojciech 9961855
Rename assert_prop_data() to assert_proportion_data().
wwojciech f2baa62
fixing typo (old function name)
wwojciech c527080
Moved assert_proportion_data() to assertions.
wwojciech d526ba0
update return update of assert_proportion_data().
wwojciech 309b252
Merge branch 'main' into 1514_add_safe_2x2_table
Melkiades ed2fea4
Fix NEWS.md version boundary for released 0.9.11
Melkiades 6e1bb2b
update man of assert_proportion_data() and save_2x2_table().
wwojciech 2eb1daf
Updating s_test_proportion_diff() to use new safe_2x2_table(). Extend…
wwojciech 71ada97
solve critical typo in s_test_proportion_diff().
wwojciech a8241f7
Cosmetic refactoring of s_test_proportion_diff().
wwojciech 0455472
seealso roxygen tag update for s_test_proportion_diff().
wwojciech 10ce5f2
Added: get_complete_cases() and h_prepare_2x2_table() - it replaces s…
wwojciech b95ace9
Added the `val` argument to `s_test_proportion_diff()`
wwojciech 947922e
cosmetic s_test_proportion_diff() update.
wwojciech 29ab62f
Set default value for val argument of h_prepare_2x2_table(). Add unit…
wwojciech ec17104
Correct lintr and add few more unit tests for h_prepare_2x2_table().
wwojciech 86534d4
Added the val argument and refactored s_proportion_diff() so that it …
wwojciech d9ff1a7
Merge branch 'main' into 1514_add_safe_2x2_table
wwojciech fbec52c
minor implementation change of h_prepare_2x2_table() - merge df_ref w…
wwojciech fa8ad40
Cosmetic update of the code comment for h_prepare_2x2_table().
wwojciech 6d37d49
Add seealso roxygen tag for s_proportion_diff().
wwojciech 62888af
Added better assertions for s_proportion_diff() and s_test_proportion…
wwojciech 73b8955
Added unit tests for new some assertions for s_test_proportion_diff()…
wwojciech b4c675a
Minor unit test update for s_proportion_diff().
wwojciech c713d24
Added new assert_stratification_compatibility() function (with unit t…
wwojciech 08694b2
s_proportion_diff() cosmetic update.
wwojciech 37cd537
s_test_proportion_diff() important assertion update.
wwojciech ee1e892
Cosmetic update h_prepare_2x2_table().
wwojciech 88a3bc6
Solves issue #1521.
wwojciech 177a582
Cosmetic update to s_proportion_diff().
wwojciech 69b3ae6
Cosmetic chnage for s_test_proportion_diff().
wwojciech ce07a3b
Adressing PR review about weights_method.
wwojciech 22ed590
Removed assertions for some variables that are passed untouched into …
wwojciech 5d93889
Merge branch 'main' into 1514_add_safe_2x2_table
wwojciech d246751
Renamed 2 variables in s_test_proportion_diff() and s_proportion_diff().
wwojciech 0e3bf2c
Adressed PR review suggestions for s_test_proportion_diff(), s_propor…
wwojciech a4bcad7
Merge branch 'main' into 1514_add_safe_2x2_table
wwojciech 463eaea
added assertion for variables in s_test_proportion_diff().
wwojciech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.