use dev shinylive; remove temp webr automation #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelru
commented
Nov 27, 2025
Comment on lines
-54
to
-76
| # temporary! | ||
| # remove this step if closed (& relleased): https://github.com/quarto-ext/shinylive/issues/59 | ||
| - name: Remove large WebR assets 🧹 | ||
| run: | | ||
| packages_path <- sprintf("./_site/site_libs/quarto-contrib/shinylive-%s/shinylive/webr/packages", shinylive::assets_version()) | ||
| # remove the dirs with size > 100 MB | ||
| for (x in list.dirs(packages_path)) { | ||
| x_files <- file.info(list.files(x, full.names = TRUE)) | ||
| if (any(x_files$size > 100 * 1024^2)) { | ||
| print(x) | ||
| print(x_files) | ||
| unlink(x, recursive = TRUE) | ||
| } | ||
| } | ||
| # refresh the `metadata.rds` file | ||
| metadata_path <- file.path(packages_path, "metadata.rds") | ||
| metadata <- readRDS(metadata_path) | ||
| new_metadata <- metadata[intersect(names(metadata), list.dirs(packages_path, full.names = FALSE))] | ||
| saveRDS(new_metadata, metadata_path) | ||
| shell: Rscript {0} | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
clean-up: not needed anymore as the issue was closed
pawelru
commented
Nov 27, 2025
Collaborator
Author
There was a problem hiding this comment.
clean-up after my mistakenly pushed commit to main
pawelru
commented
Nov 27, 2025
Comment on lines
-6
to
-10
| ```{r} | ||
| #| include: false | ||
| shinylive::assets_ensure() | ||
| ``` | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
clean-up after my mistakenly pushed commit to main
pawelru
commented
Nov 27, 2025
Comment on lines
-10
to
-11
| pre-render: | ||
| - interactive/prepare.R |
pawelru
commented
Nov 27, 2025
Comment on lines
+61
to
+62
| Remotes: | ||
| shinylive=posit-dev/r-shinylive |
Collaborator
Author
There was a problem hiding this comment.
this is the main fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #108
First of all, this PR should also include one more commit that I accidentally pushed directly to main: f5e6c47. Sorry about that! My oversight!
List of changes:
use pre-script to upgrade shinylive assetsUPDATE: not needed. devel shinylive pulls the newest assets automatically - no need for being explicit on thisI think that it might be connected to posit-dev/r-shinylive#157. There is a comment that it got fixed on Sept (link) but the latest release of this package is from Nov 2024 which means that we need to use devel version. If we use the devel version we can also use newer assets (which might include the fix - I don't really know where it's fixed: package or assets) - we can't use newer assets using released version of package
Difference:
last build on feature branch (link)
On main (but not that one commit that I pushed accidentally) (link)
Unfortunately we can't really check if it works as we don't deploy from feature branch. Hence I would suggest to merge as is and let's check if it works. We can continue from there.