Repository navigation
Custom slot: a failed create is remembered per size and flags - #79
Merged
Merged
Conversation
The key of a remembered failed create held the backend name and the option string only. A create that failed for a reason tied to the size (out of memory at 4K) therefore blocked every later create in the session, at any size. The key now also holds maxRenderSize, maxUpscaleSize and the create flags: the same parameters are still stopped, another size gets its own attempt. Fixes #60 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
What was wrong
In the custom slot, a failed create is remembered under
FailureKey, which held the backend name and the option string only. It did not includemaxRenderSize,maxUpscaleSizeor the create flags. A create that failed for a reason tied to the size (for example out of VRAM at 4K) therefore blocked every later create for the rest of the session, at any size, and the host's own upscaler stayed in use until the game restarted.The fix
FrontEnd::FailureKey(clean/fsr/src/frontend.cpp) now also holdsmaxRenderSize,maxUpscaleSizeandcreate.flags. A host that re-creates with the same parameters is still stopped; a resolution change gets its own attempt. A permanently broken runtime now fails once for each distinct size and flags instead of once in total, which is bounded and still logged. The optional retry of transient errors from the issue is not part of this change.The test
TestCustomSlotFailureKeyHasSizeinclean/fsr/tests/test_frontend.cpp(ctestfsr_frontend_unit, part of the CI set). The fake runtime fails a create whileoutput_width == 3840(a newg_failCreateOutputWidthswitch). It checks that:Before / after (MSVC, Release,
cmake -S clean/fsr -B <out> -G Ninja -DWG_MODEL_K=OFF -DWG_BUILD_ID=ci -DWG_BUILD_ASI=ON, thencmake --build <out> --target test_frontendand<out>\test_frontend.exe):1135 checks, 6 failures(all in the new test: the 2560x1440 create is refused as "failed earlier").1135 checks, 0 failures.Tested
test_frontendas above, before and after.ctest -R "unit|hosted|diagnostic|support" -E "overlay|split|d3d12") plusfsr_custom_slot(WARP): 16 tests, all passed (fsr_asi_scan_unitskipped, as usual).Not tested