Repository navigation
test_model_filter: fall back to MSVC on Windows - #45
Merged
Merged
Conversation
The module skipped every loader test on Windows unless clang++ or g++ was on PATH. After CXX, clang++ and g++ it now tries MSVC cl: directly when it is on PATH (a developer prompt, CI), else through the newest Visual Studio's vcvars64.bat (vswhere), so CI runs these tests. Fixes #20 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean/tests/test_model_filter.pyskipped all its loader tests on Windows unless clang++ or g++ was on PATH. AfterCXX, clang++ and g++ it now tries MSVCcl: directly when it is on PATH (a developer prompt, CI's MSVC step), elsethrough the newest Visual Studio's
vcvars64.batfound with vswhere, likeclean/k/tests/test_k_runtime_tables.py.Fixes #20
Tested
python -m unittest clean.tests.test_model_filter -von Windows with no clang++, g++ or cl on PATH (the vcvars64route): 14 tests, OK (on main the loader tests skip there).
Not tested
clroute (cl already on PATH) is what CI uses; its run on this pull request is the test.