Skip to content

test_model_filter: fall back to MSVC on Windows - #45

Merged
phantoslayer21 merged 1 commit into
mainfrom
20-model-filter-msvc
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
20-model-filter-msvc

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

clean/tests/test_model_filter.py skipped all its loader tests on Windows unless clang++ or g++ was on PATH. After
CXX, clang++ and g++ it now tries MSVC cl: directly when it is on PATH (a developer prompt, CI's MSVC step), else
through the newest Visual Studio's vcvars64.bat found with vswhere, like clean/k/tests/test_k_runtime_tables.py.

Fixes #20

Tested

  • python -m unittest clean.tests.test_model_filter -v on Windows with no clang++, g++ or cl on PATH (the vcvars64
    route): 14 tests, OK (on main the loader tests skip there).

Not tested

  • The direct-cl route (cl already on PATH) is what CI uses; its run on this pull request is the test.
  • Linux / clang++ route: unchanged code path.

The module skipped every loader test on Windows unless clang++ or g++ was on
PATH. After CXX, clang++ and g++ it now tries MSVC cl: directly when it is on
PATH (a developer prompt, CI), else through the newest Visual Studio's
vcvars64.bat (vswhere), so CI runs these tests.

Fixes #20

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 19:11
@phantoslayer21
phantoslayer21 merged commit c793823 into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the 20-model-filter-msvc branch November 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run clean/tests/test_model_filter.py with MSVC on Windows

1 participant