Repository navigation
Launcher and front-end tests: remove the C4456 and related MSVC warnings - #42
Merged
Merged
Conversation
Rename the shadowed locals (C4456) in wg_core/launcher.cpp's OptiScaler.ini carry-over loop, launcher_core_tests.cpp and coexist_tests.cpp, and the lambda parameter in ui_dump.cpp that hid a global (C4459). In the front end's test_frontend.cpp the configure-log counts are size_t, printed with %zu (C4267, C4477). No behaviour change. Fixes #19 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the shadowed locals behind the launcher build's C4456 warnings (
wg_core/launcher.cpp,tests/launcher_core_tests.cpp,tests/coexist_tests.cpp), the lambda parameter inui_dump.cppthat hid a global(C4459), and makes the front end's
test_frontend.cppconfigure-log countssize_tprinted with%zu(C4267, C4477). No behaviour change.
Fixes #19
Tested
launcher-core, coexist-core pass.
Not tested
WrongGPU.exe, needs a payload) was not rebuilt here;ui_dump.cppis part of it. CI does notbuild it either.