Skip to content

Launcher and front-end tests: remove the C4456 and related MSVC warnings - #42

Merged
phantoslayer21 merged 1 commit into
mainfrom
19-c4456-warnings
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
19-c4456-warnings

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

Renames the shadowed locals behind the launcher build's C4456 warnings (wg_core/launcher.cpp,
tests/launcher_core_tests.cpp, tests/coexist_tests.cpp), the lambda parameter in ui_dump.cpp that hid a global
(C4459), and makes the front end's test_frontend.cpp configure-log counts size_t printed with %zu
(C4267, C4477). No behaviour change.

Fixes #19

Tested

  • Launcher core build in the CI configuration: 0 compiler warnings (main: 15 C4456); source-size, wording, wg-core,
    launcher-core, coexist-core pass.
  • FSR front end CPU tests (CI configuration) pass.
  • Line-ending check.

Not tested

  • The full launcher (WrongGPU.exe, needs a payload) was not rebuilt here; ui_dump.cpp is part of it. CI does not
    build it either.

Rename the shadowed locals (C4456) in wg_core/launcher.cpp's OptiScaler.ini
carry-over loop, launcher_core_tests.cpp and coexist_tests.cpp, and the lambda
parameter in ui_dump.cpp that hid a global (C4459). In the front end's
test_frontend.cpp the configure-log counts are size_t, printed with %zu
(C4267, C4477). No behaviour change.

Fixes #19

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 19:06
@phantoslayer21
phantoslayer21 merged commit 4c255cd into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the 19-c4456-warnings branch November 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the C4456 shadowing warnings of the launcher build

1 participant