Skip to content

Launcher: read WRONGGPU_HIP_RUNTIME only in test builds - #41

Merged
phantoslayer21 merged 1 commit into
mainfrom
25-hip-setting-testing-only
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
25-hip-setting-testing-only

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

WRONGGPU_HIP_RUNTIME is a developer-only override of the HIP runtime search. Release builds read it too, so a value
left on a PC could change which HIP library an install recorded in hip-runtime.txt. Now only a WRONGGPU_TESTING
build reads it; a release build searches System32, PATH, the ROCm folders and HIP_PATH as before.

Fixes #25

Tested

  • Launcher core CPU tests in the CI configuration (WRONGGPU_TESTING=OFF): source-size, wording, wg-core,
    launcher-core, coexist-core pass. wg-core's new case points the variable at a stand-in file in its temp folder
    (nothing is loaded) and checks that the release build never names it.
  • Line-ending check.

Not tested

  • The testing-build half of the new wg-core case (WRONGGPU_TESTING=ON: tries the variable first) was not run here;
    CI builds the release configuration only.
  • The installer and launcher suites, which use testing builds (unchanged behaviour there).

The HIP runtime check took the developer-only WRONGGPU_HIP_RUNTIME setting in
release builds too, so a leftover value on a PC could change which HIP library
an install recorded. Only a WRONGGPU_TESTING build reads it now; a release build
searches System32, PATH, the ROCm folders and HIP_PATH as before.

Test: wg-core points the variable at a stand-in file (nothing is loaded): a
testing build tries it first, a release build never names it.

Fixes #25

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 19:03
@phantoslayer21
phantoslayer21 merged commit 06a280a into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the 25-hip-setting-testing-only branch November 13, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launcher: read the developer-only HIP runtime setting only in test builds

1 participant