Repository navigation
Launcher: read WRONGGPU_HIP_RUNTIME only in test builds - #41
Merged
Merged
Conversation
The HIP runtime check took the developer-only WRONGGPU_HIP_RUNTIME setting in release builds too, so a leftover value on a PC could change which HIP library an install recorded. Only a WRONGGPU_TESTING build reads it now; a release build searches System32, PATH, the ROCm folders and HIP_PATH as before. Test: wg-core points the variable at a stand-in file (nothing is loaded): a testing build tries it first, a release build never names it. Fixes #25 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WRONGGPU_HIP_RUNTIMEis a developer-only override of the HIP runtime search. Release builds read it too, so a valueleft on a PC could change which HIP library an install recorded in
hip-runtime.txt. Now only aWRONGGPU_TESTINGbuild reads it; a release build searches System32, PATH, the ROCm folders and
HIP_PATHas before.Fixes #25
Tested
WRONGGPU_TESTING=OFF): source-size, wording, wg-core,launcher-core, coexist-core pass. wg-core's new case points the variable at a stand-in file in its temp folder
(nothing is loaded) and checks that the release build never names it.
Not tested
WRONGGPU_TESTING=ON: tries the variable first) was not run here;CI builds the release configuration only.