Skip to content

Uninstaller "Collect logs": model data it cannot check is "not verified here", not invalid - #40

Merged
phantoslayer21 merged 1 commit into
mainfrom
24-collect-logs
Nov 13, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
24-collect-logs

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

A game's uninstall.exe is built without the converter map, so "Collect logs" run from it reported
"Model data: not usable (the embedded converter map is invalid)" even when the model was fine.

  • uninstall.exe now reports what it can see: the model file's presence and size, "not verified here", and a pointer
    to Collect logs in the launcher, which can verify it. The launcher's own report is unchanged.
  • Its report no longer has empty version fields, and its file list comes from the install record (WrongGPU's runtime,
    plugins and text files), since uninstall.exe has no payload table.

Fixes #24

Tested

  • Launcher core CPU tests (MSVC, Release, WRONGGPU_TESTING=OFF, the CI configuration): source-size, wording, wg-core,
    launcher-core, coexist-core pass; launcher-core includes the new uninstall.exe case.
  • Line-ending check.

Not tested

  • The installer suite's new Collect-logs-through-uninstall.exe case in run_installer_tests.py (it needs a full
    launcher build with a payload; not part of CI).

…ed here", not invalid

A game's uninstall.exe is built without the converter map, so its Collect logs
report called valid model data invalid. It now reports the model file's presence
and size and says the data is not verified there; the launcher's own report is
unchanged. The bundle also lists WrongGPU's files and has no empty version fields.

Tests: launcher-core covers the uninstall.exe case; the installer suite runs
Collect logs through uninstall.exe in every build configuration.

Fixes #24

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 13, 2026 18:50
@phantoslayer21
phantoslayer21 merged commit e42db76 into main Nov 13, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the 24-collect-logs branch November 13, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstaller "Collect logs": valid model data reported as invalid

1 participant