Repository navigation
Uninstaller "Collect logs": model data it cannot check is "not verified here", not invalid - #40
Merged
Merged
Conversation
…ed here", not invalid A game's uninstall.exe is built without the converter map, so its Collect logs report called valid model data invalid. It now reports the model file's presence and size and says the data is not verified there; the launcher's own report is unchanged. The bundle also lists WrongGPU's files and has no empty version fields. Tests: launcher-core covers the uninstall.exe case; the installer suite runs Collect logs through uninstall.exe in every build configuration. Fixes #24 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A game's
uninstall.exeis built without the converter map, so "Collect logs" run from it reported"Model data: not usable (the embedded converter map is invalid)" even when the model was fine.
uninstall.exenow reports what it can see: the model file's presence and size, "not verified here", and a pointerto Collect logs in the launcher, which can verify it. The launcher's own report is unchanged.
plugins and text files), since
uninstall.exehas no payload table.Fixes #24
Tested
WRONGGPU_TESTING=OFF, the CI configuration): source-size, wording, wg-core,launcher-core, coexist-core pass; launcher-core includes the new
uninstall.execase.Not tested
uninstall.execase inrun_installer_tests.py(it needs a fulllauncher build with a payload; not part of CI).