Repository navigation
Model K: exact speedup, certified fast log2 in the input stage (-17.25 us at 1080p Q, -31 us at 1440p Q) - #287
Merged
Merged
Conversation
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model K's tiled HDR input uses a shorter compensated FP32 log2 polynomial. It accepts the result only when the error bound certifies the rounded FP32 value. Ambiguous inputs and positive infinity use the existing log2 fallback.
1b975fbba17891e3at 1080p Q and5fb3d1ab49ad8f90at 1440p Q. Native D3D12 matched 600 frames each at odd dimensions, 1080p Q, and 1440p Q, including six saved RGBA16F frames per shape compared byte for byte. The GPU mutant changed odd frame 1.Against
c4b9b0de, one session used four paired ABBA/BAAB blocks per shape and 1,500 frames per leg. The median paired change was -17.25 us at 1080p Q and -31 us at 1440p Q. Maximum A/A differences were 0.5 us and 4.5 us, respectively.The evidence records are kept off-repo by the maintainer.
Review fixes
kf_opq. The gfx1201 ISA showsv_mul_f32feeding the correction FMA throughv_xor_b32in all three tiled-input variants. RGA reports 72, 64, and 64 VGPRs with 11,520 B LDS, zero scratch, and zero spills. All 162 DXIL manifest entries passed provenance and file-hash checks.WG_K_PHI_LOG2_FULL=1enables the exhaustive path. Both modes passed, and the CPU and kernel-set suite passed all 43 tests.1b975fbba17891e3at 1080p Q,5fb3d1ab49ad8f90at 1440p Q). All 600 native frames per shape matched the recorded baseline and REFS at odd dimensions, 1080p Q, and 1440p Q.The ABBA/BAAB re-check against
c4b9b0deused two blocks per shape and 1,500 frames per leg. Median B minus A was -18.125 us at 1080p Q (blocks -18, -18.25 us) and -30.875 us at 1440p Q (blocks -30.25, -31.5 us). Maximum A/A differences were 0 and 2 us, respectively.