Repository navigation
Model K: exact speedup, input kernel at 72 VGPRs (-28 us at 1080p Q, -48 us at 1440p Q) - #285
Merged
Merged
Conversation
…n_tiled_direct 83 -> 64 VGPR) The exact tiled direct input kernel computed KiHost and the direct motion factors (sp, offset) per lane; the values are wave-uniform, so they now go through v_readfirstlane once and live in scalar registers. Same operations in the same order, output bytes unchanged. RGA gfx1201: 83 -> 64 VGPR, 11520 B LDS, 100 SGPR, no scratch. Only kx/k_in_tiled_direct changes (every other K input / output DXIL is byte-identical).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The tiled direct input kernel (
kx/k_in_tiled_direct) computed the frame-wideuniforms (
KiHostand the direct motion factorsspandoffset) per lane.Those values are wave-uniform, so they now pass through
v_readfirstlaneonceand live in scalar registers. The same operations run in the same order, so
the output bytes do not change.
11520 B LDS (unchanged), no scratch.
kx/k_in_tiled_directchanges. Of the 159 DXIL files, the other 158 arebyte-identical to the previous build, and the runtime DLL is identical.
origin/main(e1f4679, Model L). The K input sources do notinclude any file that changed on main, so the K DXIL is unaffected by the
rebase.
Byte checks
reference values,
1b975fbba17891e3(1080p Q) and5fb3d1ab49ad8f90(1440p Q).
per-frame results equal the reference, totals equal the reference, 6 saved
frames byte-identical, no non-finite values.
66240e73d13ed096and is caught by the reference comparison.input_uniforms=gpu,out=f32) ischecked at the final-frame level only. Per-frame equality on that exact
configuration is not separately shown; the native gate uses the host-uniform
and RGBA16F path.
Timing
Block means of (B - A), where A is the previous kernel and B is this change.
Negative is faster. 16 raw runs per shape.
Stage attribution is not clean. The input stage drops by about 34 us (1080p)
and 55 us (1440p), as expected. Network and output stages read a few us slower
in the timed runs (about 4.75 us and 2 us at 1080p) even though their DXIL is
unchanged. The total still favors this change at both shapes.
Evidence records (raw run logs, comparisons, and occupancy reports) are kept
off-repo by the maintainer.