Skip to content

Model K: player-visible option text names the standard path - #265

Merged
phantoslayer21 merged 2 commits into
mainfrom
clean/k-approx-wording
Nov 16, 2026
Merged

phantoslayer21 merged 2 commits into
mainfrom
clean/k-approx-wording

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

Three pieces of Model K's player-visible option text are reworded. The wording rule avoids claims of exactness in player-visible text, so they now name the default as the standard path.

  • The create note of the opt-in k_approx option now reads "(opt-in faster approximation; the default is the standard path)". It used to read "(opt-in, not bit-exact; the default path is exact)".
  • With a1, the create note and the one-per-context legacy-input line now say that such frames "run the standard input stage", where they used to say "exact".
  • The front end's K mode line now reads ", the standard path" for the default and ", an approximation (opt-in)" for an opt-in mode. These strings live in clean/k/runtime/runtime_k.cpp and clean/runtime/interop/backend.cpp, which reach the runtime library and the launcher that carries it.

Nothing else changes in behaviour or output.

Tests:

  • clean/k/tests/test_k_option_text.py (new, host-only) checks the note, the a1 lines and the mode line for the new wording and for no "exact". It fails on the old text.
  • clean/k/tests/test_k_runtime_d3d12.py test_k_approx_each_tag checks the note on a device for a1, a2 and a1,a2.
  • clean/k/tests/test_k_approx_executor.py reads the new mode line through the interop.
    On a developer build of this branch: test_k_option_text 2/2, and test_k_approx_each_tag, test_selected_form_runs and test_unselected_form_is_not_prepared pass. The built library carries the new strings and none of the old ones.

…ctness

The player-visible create note of the opt-in k_approx option now reads "(opt-in faster approximation; the default is
the standard path)". The wording rule avoids claims of exactness in player-visible text.

Tests: test_k_option_text.py (new, host): the note's fixed part carries the new wording and no "exact";
test_k_runtime_d3d12.py test_k_approx_each_tag checks the note on a device.

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
The front end's K mode line reads ", the standard path" for the default and ", an approximation (opt-in)" for an
opt-in mode, and k_approx=a1's create note and its legacy-input line say such frames run the standard input stage.
Player-visible text; the wording rule avoids claims of exactness.

Tests: test_k_option_text.py covers the a1 lines and the mode line; test_k_approx_executor.py reads the new mode line.

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21 phantoslayer21 added this to the 0.6.5 milestone Nov 16, 2026
@phantoslayer21
phantoslayer21 merged commit aa85515 into main Nov 16, 2026
10 checks passed
@phantoslayer21
phantoslayer21 deleted the clean/k-approx-wording branch November 16, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant