Repository navigation
Model K: player-visible option text names the standard path - #265
Merged
Merged
Conversation
…ctness The player-visible create note of the opt-in k_approx option now reads "(opt-in faster approximation; the default is the standard path)". The wording rule avoids claims of exactness in player-visible text. Tests: test_k_option_text.py (new, host): the note's fixed part carries the new wording and no "exact"; test_k_runtime_d3d12.py test_k_approx_each_tag checks the note on a device. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
The front end's K mode line reads ", the standard path" for the default and ", an approximation (opt-in)" for an opt-in mode, and k_approx=a1's create note and its legacy-input line say such frames run the standard input stage. Player-visible text; the wording rule avoids claims of exactness. Tests: test_k_option_text.py covers the a1 lines and the mode line; test_k_approx_executor.py reads the new mode line. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pieces of Model K's player-visible option text are reworded. The wording rule avoids claims of exactness in player-visible text, so they now name the default as the standard path.
k_approxoption now reads "(opt-in faster approximation; the default is the standard path)". It used to read "(opt-in, not bit-exact; the default path is exact)".a1, the create note and the one-per-context legacy-input line now say that such frames "run the standard input stage", where they used to say "exact".clean/k/runtime/runtime_k.cppandclean/runtime/interop/backend.cpp, which reach the runtime library and the launcher that carries it.Nothing else changes in behaviour or output.
Tests:
clean/k/tests/test_k_option_text.py(new, host-only) checks the note, thea1lines and the mode line for the new wording and for no "exact". It fails on the old text.clean/k/tests/test_k_runtime_d3d12.pytest_k_approx_each_tagchecks the note on a device fora1,a2anda1,a2.clean/k/tests/test_k_approx_executor.pyreads the new mode line through the interop.On a developer build of this branch:
test_k_option_text2/2, andtest_k_approx_each_tag,test_selected_form_runsandtest_unselected_form_is_not_preparedpass. The built library carries the new strings and none of the old ones.