Repository navigation
BUILDING: copy the runtime's build manifest into the payload - #260
Merged
Merged
Conversation
clean/runner/build.py writes wronggpu_runtime.build.json next to the runtime library, and the payload packager refuses a runtime library without it (or one whose SHA-256 does not match it). The payload step now copies the manifest with the library and says why; the manifest is read for that check and not shipped. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payload packager (clean/installer/tools/make_payload.py) accepts a runtime library only when its build manifest, wronggpu_runtime.build.json (written by clean/runner/build.py next to the library), sits next to it and matches its SHA-256. BUILDING.md's payload step copied only wronggpu_runtime.dll, so a build that follows it is refused at packaging.
Docs only.