Skip to content

Launcher UI checks drive controls that are still there after #225; no text offers HIP - #250

Merged
phantoslayer21 merged 2 commits into
mainfrom
fix/ui-dump-probes-after-225
Nov 16, 2026
Merged

phantoslayer21 merged 2 commits into
mainfrom
fix/ui-dump-probes-after-225

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

What this changes and why

Since #225, three test_ui_dump checks failed on main: keyboard Discard returning the focus, Space acting on key-up, and Advanced settings opening by themselves. The launcher's behaviour did not regress. The dump's probes were driving controls that #225 disabled or removed:

No launcher text offers HIP as a choice any more. Searched every wide string in the launcher's source (src/app, src/wg_core) and the launcher docs for HIP.

Changed:

  • First-run check, HIP runtime not found (ui_checks.cpp, and its fixture in ui_render.cpp):
    • before: "Only Sparkle guard and the HIP choice in Runs on need it."
    • now: "Model M runs on Direct3D 12 without it."
  • Settings, HIP runtime row (ui_settings.cpp):
    • not found, before: "Only Sparkle guard and the HIP choice in Runs on need it."
    • not found, now: "Optional. Model M runs on Direct3D 12 without it, and no game setting uses it."
    • found, before: "Used by Sparkle guard and the HIP choice in Runs on."
    • found, now: "Not used in games: Model M runs on Direct3D 12."
  • Another HIP tool in a game (ui_game.cpp finding note, ui_words.cpp warning):
    • before: "Keep Runs on at Auto or Direct3D 12 so the two don't clash."
    • now: WrongGPU runs on Direct3D 12 in a game, not on HIP, so the two don't clash.
  • The segment-width measure (PageSegW) no longer measures the word "HIP". It was never shown; "HIP" is narrower than the other words, so no width changes.
  • clean/installer/README.md: executor is listed as auto | dx12, and an older profile's hip is dropped when the profile is read.

Checked and left as they are (none offers a choice):

What each new or substantially changed file is based on

Own design. No new files.

How it was tested

On Windows with MSVC, using a WRONGGPU_TESTING launcher built from the test suite's stand-in payload. APPDATA, LOCALAPPDATA, ProgramData and TMP were redirected to scratch folders.

  • run_launcher_tests.py --only ui_dump: 79 pass, 0 fail (76/3 on main).
  • run_launcher_tests.py, full suite, on the last head: 458 pass, 6 fail (main: 455 pass, 9 fail).
    • The 6 are the known checks that fail on main, which the fresh-clone suite PR handles: the uninstaller size, an older record's update, a game without RR, hash mismatch, offline without the player's download, and plain http.
    • The 3 UI checks pass.
  • The store-access log: no store library path read. The only access outside the test folders was the Steam registry key, and it was refused.

Checklist

  • I make the clean-room statement of CONTRIBUTING.md for this and all my contributions (required once, in my first pull request).
  • Every commit has a Signed-off-by: line (git commit -s; Developer Certificate of Origin 1.1).
  • New source files carry the SPDX licence line for MIT, or are covered in REUSE.toml. (No new files.)
  • No files of the original upscaler (see CONTRIBUTING.md), no model data, game files, captures, screenshots or binaries; no paths, user or machine names of my PC.
  • Any new third-party component is under a permitted licence and listed in THIRD-PARTY-NOTICES and REUSE.toml. (None.)
  • Numbers in documents come with their measurement record. (None added.)
  • Kernel or runtime changes: none.

Three test_ui_dump checks failed on main since #225. The launcher's behaviour is unchanged;
their probes drove controls #225 took away:

- Discard from the keyboard and Space on key-up acted on Sparkle guard, which is now off and
  disabled (no Direct3D 12 port). A disabled switch takes no focus and no Space, so the focus
  went to another stop and Space did nothing. Both now use Pre-exposure's Original.
- Advanced settings opening for a saved value off its default saved Runs on as HIP, which is
  no longer a Runs on value (auto|dx12), so nothing was saved. It now saves Direct3D 12. The
  unsaved-change case changes Pre-exposure instead of Sparkle guard.

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Since #225 Runs on offers Auto and Direct3D 12 only. The first-run check and Settings' HIP
runtime row still said the HIP choice in Runs on needed the runtime, and the note about another
HIP tool said to keep Runs on at Auto or Direct3D 12. They now say Model M runs on Direct3D 12
without it and that WrongGPU doesn't use HIP in a game. The installer README lists executor as
auto | dx12.

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21 phantoslayer21 added this to the 0.6.5 milestone Nov 16, 2026
@phantoslayer21 phantoslayer21 added the area: launcher Launcher and installer label Nov 16, 2026
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 16, 2026 00:11
@phantoslayer21
phantoslayer21 merged commit f15132d into main Nov 16, 2026
10 checks passed
@phantoslayer21
phantoslayer21 deleted the fix/ui-dump-probes-after-225 branch November 16, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: launcher Launcher and installer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant