Repository navigation
Launcher UI checks drive controls that are still there after #225; no text offers HIP - #250
Merged
Merged
Conversation
Three test_ui_dump checks failed on main since #225. The launcher's behaviour is unchanged; their probes drove controls #225 took away: - Discard from the keyboard and Space on key-up acted on Sparkle guard, which is now off and disabled (no Direct3D 12 port). A disabled switch takes no focus and no Space, so the focus went to another stop and Space did nothing. Both now use Pre-exposure's Original. - Advanced settings opening for a saved value off its default saved Runs on as HIP, which is no longer a Runs on value (auto|dx12), so nothing was saved. It now saves Direct3D 12. The unsaved-change case changes Pre-exposure instead of Sparkle guard. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Since #225 Runs on offers Auto and Direct3D 12 only. The first-run check and Settings' HIP runtime row still said the HIP choice in Runs on needed the runtime, and the note about another HIP tool said to keep Runs on at Auto or Direct3D 12. They now say Model M runs on Direct3D 12 without it and that WrongGPU doesn't use HIP in a game. The installer README lists executor as auto | dx12. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
Since #225, three
test_ui_dumpchecks failed on main: keyboard Discard returning the focus, Space acting on key-up, and Advanced settings opening by themselves. The launcher's behaviour did not regress. The dump's probes were driving controls that #225 disabled or removed:autoordx12, so the value wasn't saved and the default stayed. The probe now saves Direct3D 12. The unsaved-change case changes Pre-exposure instead of Sparkle guard, so it uses a setting a player can still change.No launcher text offers HIP as a choice any more. Searched every wide string in the launcher's source (
src/app,src/wg_core) and the launcher docs for HIP.Changed:
ui_checks.cpp, and its fixture inui_render.cpp):ui_settings.cpp):ui_game.cppfinding note,ui_words.cppwarning):PageSegW) no longer measures the word "HIP". It was never shown; "HIP" is narrower than the other words, so no width changes.clean/installer/README.md:executoris listed as auto | dx12, and an older profile'shipis dropped when the profile is read.Checked and left as they are (none offers a choice):
hip: names a value someone wrote into the profile.WrongGPU.exe --check-hip: command-line diagnostics.RELEASE-NOTES.md: past releases.What each new or substantially changed file is based on
Own design. No new files.
How it was tested
On Windows with MSVC, using a
WRONGGPU_TESTINGlauncher built from the test suite's stand-in payload. APPDATA, LOCALAPPDATA, ProgramData and TMP were redirected to scratch folders.run_launcher_tests.py --only ui_dump: 79 pass, 0 fail (76/3 on main).run_launcher_tests.py, full suite, on the last head: 458 pass, 6 fail (main: 455 pass, 9 fail).Checklist
Signed-off-by:line (git commit -s; Developer Certificate of Origin 1.1).REUSE.toml. (No new files.)