Repository navigation
Test launchers build again from the test suite's stand-in payload - #249
Merged
Merged
Conversation
Since the payload gate (#225), a WRONGGPU_TESTING launcher built from the mock payload stopped at "Embedding the payload": the stand-in runtime had no "wg-build dev-diagnostics=0" marker and no build manifest. - The suite's prepare step (run_installer_tests.py --prepare-only) writes the stand-in runtime with the marker and a build manifest for its exact bytes that says stand_in. - make_payload.py embeds a stand-in runtime only with --testing, which CMake passes in WRONGGPU_TESTING builds; any other build refuses it at the payload step. A real payload is checked exactly as before. - CI builds the testing launcher from the stand-in payload and checks that a release build with the same payload refuses it (the negative control). The packager tests cover the stand-in with and without --testing. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
…step with its exit code Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 15, 2026 23:37
phantoslayer21
added a commit
that referenced
this pull request
Nov 15, 2026
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
Since the payload gate in #225, a
WRONGGPU_TESTINGlauncher built from the test suite's mock payload stops at "Embedding the payload". The stand-in runtime in that payload has nowg-build dev-diagnostics=0marker and no.build.jsonmanifest, so the gate refuses it, correctly. The local launcher test runs and anyone building a test launcher from--prepare-onlyhit this.tests/run_installer_tests.py --prepare-only,stand_in_runtime) writes the stand-in runtime with the release marker, plus a build manifest for its exact bytes (format 1, its SHA-256,dev_diagnostics: false) that saysstand_in: true.tools/make_payload.pyaccepts a runtime whose manifest saysstand_inonly with--testing, which CMake passes inWRONGGPU_TESTINGbuilds. Any other build stops at the payload step with "the test suite's stand-in runtime ... only a WRONGGPU_TESTING build embeds it".--testing. Release packaging (tools/release) is unchanged.--testingandWRONGGPU_TESTING:BUILDING.md's release and developer-package commands configure with-DWRONGGPU_TESTING=OFF, so CMake passes no--testing.tools/release/check_package_diagnostics.py(the final package check) has neither.tools/ci/check_release_runtime.py, which runs the real packager on a real runtime in CI, callsmake_payload.pywithout--testing.--testingorWRONGGPU_TESTING=ONareCMakeLists.txtforWRONGGPU_TESTINGbuilds, the test runners (run_installer_tests.py,build-mingw.sh's default,clean/linux/run_wine_tests.py) and this CI step.WRONGGPU_TESTING=OFF) with the same payload and checks that its payload step refuses the stand-in for that reason.clean/tests/test_dev_diagnostics_off.py):--testingand embedded with it;--testing, a stand-in without the marker, one whose bytes changed after its manifest, and a runtime without a manifest are still refused.make_payloadcheck (--hosted-only) uses the same stand-in. The installer README says how to build a test launcher from the mock payload.build-mingw.sh(the MinGW build thattests/run_installer_tests.pymakes under Wine, also used by outside contributors) is now aWRONGGPU_TESTINGbuild and passes--testingtomake_payload.py, so it embeds the stand-in.RELEASE=1 ./build-mingw.sh ...makes a release-type MinGW build (noWRONGGPU_TESTING, no--testing). It still refuses the stand-in at the payload step: the negative control. CMake with a MinGW toolchain file follows the sameWRONGGPU_TESTINGrule as MSVC.build-mingw.shitself, it setsWRONGGPU_TESTING=1, so its Apps & features root and its testing-only cases match the build.What each new or substantially changed file is based on
Own design.
How it was tested
Tested on this head (Windows, MSVC; APPDATA, LOCALAPPDATA, ProgramData and TMP redirected to scratch folders):
clean/tests/test_dev_diagnostics_off.py: 12/12 pass, including the new stand-in cases.--prepare-only:WRONGGPU_TESTINGlauncher built from it with CMake builds (it stopped at "Embedding the payload" before this change). Itslauncher-core-tests: 480 checks pass.WRONGGPU_TESTING=OFF) with the same payload stops at the payload step with the stand-in refusal.build-mingw.sh's payload step, run here up to the compiler: it embeds the stand-in by default (testing) and refuses it withRELEASE=1(the stand-in refusal, no payload table written).run_launcher_tests.py, full suite, with the launcher built from the stand-in payload. The RR test game's rr-prepare was answered without the GPU.test_ui_dump: "Discard from the keyboard ... focus goes back", "Space acts as it comes up ...", and "Advanced settings open by themselves ...". They fail the same way when that test is run again alone. This PR changes no UI code; main's UI changed in R1: no in-game route to HIP; GPU identity from the driver; other cards use the front end's upscaler #225 (ui_game.cpp,ui_checks.cpp,ui_activate.cpp). They are reported separately.Not tested:
Checklist
Signed-off-by:line (git commit -s; Developer Certificate of Origin 1.1).REUSE.toml. (No new files.)