Repository navigation
CI: build the front end and launcher with the release's model flags (Model L and K on) - #238
Merged
Merged
Conversation
…odel flags (Model L and K on) Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.6.5 release builds the front end and launcher with Model L and Model K on (
-DWG_MODEL_K=ON -DWG_MODEL_L=ON;-DWRONGGPU_PRESET_K=ON -DWRONGGPU_MODEL_K=ON -DWRONGGPU_MODEL_L=ON), but CI only ever configured the Model M-onlyvariant (
-DWG_MODEL_K=OFF,-DWRONGGPU_PRESET_K=OFF). A change that breaks the build players get could pass CI.This adds one CPU job,
release-models("CPU: release model flags (Model L and K on)"), next to the existing ones:-DWG_MODEL_K=ON -DWG_MODEL_L=ON, built, and its CPU tests run (the samectestselection as the front-end job);
-DWRONGGPU_PRESET_K=ON -DWRONGGPU_MODEL_K=ON -DWRONGGPU_MODEL_L=ON(and the HIP runtimestand-in), its core and model-choice test targets built and run (the same selection as the launcher job).
No GPU, no payload, no game. The existing jobs keep the Model M-only configuration, so both states stay built. The job is
added to
build-and-test'sneeds, so the required "CPU build and tests" check covers it.The matching BUILDING.md change (release commands with Model L and Model K) is a separate PR.