Repository navigation
docs: BUILDING release commands build Model L and Model K in (0.6.5) - #237
Merged
Merged
Conversation
… ships them Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.6.5 ships Model L and Model K next to Model M (Model M stays the default; L and K are choices per game). BUILDING.md's
release commands still built a Model M-only release (
--no-model-k,-DWG_MODEL_K=OFF,-DWRONGGPU_PRESET_K=OFF, noModel L flags), so a 0.6.5 built from it would have had neither model, while the 0.6.5 release notes describe both.
Changes (docs only):
build_dx12.py --model-l --model-k(the D3D12 kernels of all three models).build.py ... --model-linstead of--no-model-k(Model K is in the runtime unless--no-model-k).-DWG_MODEL_K=ON -DWG_MODEL_L=ON(WG_MODEL_Ldefaults to OFF).-DWRONGGPU_PRESET_K=ON -DWRONGGPU_MODEL_K=ON -DWRONGGPU_MODEL_L=ON(WRONGGPU_MODEL_LandWRONGGPU_MODEL_Kdefault to OFF).three parts must agree, and keeps the Model M-only variant for comparisons.
These are the flags of the 0.6.5 release-candidate build that was tested in game: D3D12 kernels with
--model-l --model-k, runtime with--model-land Model K, front end withWG_MODEL_K=ONandWG_MODEL_L=ON, launcher withWRONGGPU_PRESET_K,WRONGGPU_MODEL_KandWRONGGPU_MODEL_LON. In Cyberpunk 2077 that build ran Model K on Direct3D 12in the game's command list, with no HIP runtime loaded in the game process.
CI is unchanged here; a separate PR adds a job that configures the Model K/L-on launcher and front end.