Repository navigation
tools/release: B8 release check (real-pixel refused-frame test against a build's runtime DLL) - #229
Draft
phantoslayer21 wants to merge 1 commit into
Draft
phantoslayer21 wants to merge 1 commit into
phantoslayer21 wants to merge 1 commit into
Conversation
…egration test against a build's runtime DLL Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 15, 2026 03:29
phantoslayer21
marked this pull request as draft
November 15, 2026 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release check for 0.6.5 item B8 (oversight's #228 decision): a repository-defined check under
tools/release/with a working build command. It builds and runs the real-pixel integration test of the normal refused-frame paths (AMD FSR present / absent, the stand-in working / unavailable, the backend's last resort checked on every output pixel, model K and the model M control) against a build's own runtime DLL. The CI can't run it, because there is no runtime DLL there. The release lead runs it on the release candidate in C3.tools/release/run_refusal_check.py --runtime-dll <build>\wronggpu_runtime.dll --work <new scratch folder>:clean/wgshared/tools/gen_registry.py);clean/fsr/tests/test_refusal_integration.cpp, kept current by the test's owner in B8: a refused frame always has an explicit result; front end tested against the real backend #228;{a,b}.cppgroups expanded; a built-in list only if the header has none), inside the Visual Studio developer environment (vswhere → VsDevCmd) for the Windows SDK's d3d12 / dxgi;The test run gets APPDATA, LOCALAPPDATA, ProgramData (and ALLUSERSPROFILE), TMP and TEMP redirected into the work folder. The compile moves only TMP / TEMP, because VsDevCmd needs the real ProgramData to find Visual Studio. The result goes to
<work>\refusal-check.json. The exit code is the test's. A missing DLL or test file fails the check, never skips it.tools/release/README.mdlists the release checks (this one for now).Tested (on this PC, against #228's head ede7894 in a scratch worktree with the script copied in):
clean/fsr/src/passthrough_d3d12.cpp, which B8: a refused frame always has an explicit result; front end tested against the real backend #228 deleted in 26633de, so the documented command doesn't build as written. With that one name dropped locally (not pushed) it builds. The header is B8: a refused frame always has an explicit result; front end tested against the real backend #228's to fix; this script follows it.Gates: the must-pass gates pass. LOOK counts equal main's (42 / 29 / 133).
Refs #15.