Repository navigation
Tools (in-game): the launcher's install / update / uninstall through an optional GPU slot - #202
Merged
Merged
Conversation
…an optional GPU slot
The launcher's install, repair, update, uninstall and rollback checks run a short HIP probe on the GPU. run.py called update directly, so on a shared PC that probe ran outside the PC's GPU-slot rule. An optional config entry gpu_slot ({"command": [prefix], "env": {...}}) now wraps exactly those verbs; play is not wrapped. Without it the session log says the probe ran outside a slot. Checked with a dry run both ways.
Refs #89
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
The launcher's install, repair, update, uninstall and rollback checks run a short HIP probe on the GPU ("HIP probe: context created", under a second).
tools/ingame/run.pycalledupdatedirectly, so on a PC that shares its GPU through a slot tool, that probe ran outside the slot rule.gpu_slot:{"command": [<prefix that runs one command in a GPU slot>], "env": {...}}. Exactly those five verbs run through it;playdoes not.Checked:
all --dry-runwith and withoutgpu_slot(the update line is wrapped, or the note appears). No runtime or build change.